From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500DDC433F5 for ; Mon, 31 Jan 2022 15:20:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45FF6B00B5; Mon, 31 Jan 2022 10:20:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4886B00B7; Mon, 31 Jan 2022 10:20:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB9A6B00B8; Mon, 31 Jan 2022 10:20:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 899146B00B5 for ; Mon, 31 Jan 2022 10:20:08 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 48EE193696 for ; Mon, 31 Jan 2022 15:20:08 +0000 (UTC) X-FDA: 79090942896.21.807B8CD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 8F92CA0006 for ; Mon, 31 Jan 2022 15:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X5Q5MeJDTPKbLPeAN2MtOT5sSDrTeYy1qnQ5DDAxIaY=; b=tweIhqfFo7IPJLtRc+U6X4zRG/ yGm17K8r35WfAR1Z3Pp5jZxTwu9pS7l19D8MHHoo5lF5gnMczM/vo5M83IEWaQh8VV5t3juB2KeUi FosS5h8/Iy9TMCHzNWSo1qVBt8JU+YzraXxCN5TExHIZ1HqlVL5IcM6O61ZztEHlFHrtqIbHmwcT9 wIR367tJqAZz5kaPc8FgVVfgeZhphtApIxBizRqkI+DK9dejx2UTl04bqKRd6F05qMYG8niBfwh0Q RlDz4gojjsluqPiWShSfQRBoez5P6tZEIwL2XRyRrJN280TOC7AHKMqGn5gdCPBure6k7Mzj1qiDf 1AxoS7vQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEYSg-00A1w0-Mx; Mon, 31 Jan 2022 15:19:22 +0000 Date: Mon, 31 Jan 2022 15:19:22 +0000 From: Matthew Wilcox To: Christian Brauner Cc: kernel test robot , Kees Cook , Ariadne Conill , 0day robot , Michael Kerrisk , Rich Felker , Eric Biederman , Alexander Viro , LKML , lkp@lists.01.org, Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [fs/exec] 80bd5afdd8: xfstests.generic.633.fail Message-ID: References: <20220127000724.15106-1-ariadne@dereferenced.org> <20220131144352.GE16385@xsang-OptiPlex-9020> <20220131150819.iuqlz3rz6q7cheap@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131150819.iuqlz3rz6q7cheap@wittgenstein> X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8F92CA0006 X-Stat-Signature: gpftpwd4k3qokhqacf4ssudp8zt7df1u Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tweIhqfF; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1643642407-713819 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 31, 2022 at 04:08:19PM +0100, Christian Brauner wrote: > On Mon, Jan 31, 2022 at 10:43:52PM +0800, kernel test robot wrote: > I can fix this rather simply in our upstream fstests with: > > static char *argv[] = { > "", > }; > > I guess. > > But doesn't > > static char *argv[] = { > NULL, > }; > > seem something that should work especially with execveat()? The problem is that the exec'ed program sees an argc of 0, which is the problem we're trying to work around in the kernel (instead of leaving it to ld.so to fix for suid programs).