From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB50BC433EF for ; Mon, 31 Jan 2022 05:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49B636B0073; Mon, 31 Jan 2022 00:52:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44B686B0088; Mon, 31 Jan 2022 00:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A186B0089; Mon, 31 Jan 2022 00:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 243FE6B0073 for ; Mon, 31 Jan 2022 00:52:48 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CA47997306 for ; Mon, 31 Jan 2022 05:52:47 +0000 (UTC) X-FDA: 79089513174.20.436B137 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 499ADA0003 for ; Mon, 31 Jan 2022 05:52:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13C6E212C5; Mon, 31 Jan 2022 05:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643608366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r03ryjoJE+I6jzeUO7ZpiYA0DNC9txWpejJG0PG2+qM=; b=nWRTUQnMtTQ0XajvwGyACUJrKXAzwLaW6bsouECJ5eaW756sAFyWi18iG0WynWFmi7vADu 9lvU6yssBQRb9beLwQKbuwbNAQig7yXWs5W1zpl++9pF/TVjV11Fmczd66E5rTMXzgpboZ 3AJD5s2B4a9Gwnpgws8zcfHXtornNa0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643608366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r03ryjoJE+I6jzeUO7ZpiYA0DNC9txWpejJG0PG2+qM=; b=c3IAuy/cxQipjTDZ8VfHJwIx7X15VJGypjt3Ee8Jwp0yWobMYiJaGIU7iwTgsRvXo73jd0 q/LPuYQInLm72lAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 848B113638; Mon, 31 Jan 2022 05:52:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cShhHS1592FYJwAAMHmgww (envelope-from ); Mon, 31 Jan 2022 05:52:45 +0000 Date: Mon, 31 Jan 2022 06:52:43 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Michal Hocko Subject: Re: [PATCH v1] drivers/base/memory: add memory block to memory group after registration succeeded Message-ID: References: <20220128144540.153902-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128144540.153902-1-david@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 499ADA0003 X-Stat-Signature: rf5yajswfupequ1ejwqzefcbj81nqred X-Rspam-User: nil Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nWRTUQnM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="c3IAuy/c"; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1643608367-64608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 03:45:40PM +0100, David Hildenbrand wrote: > If register_memory() fails, we freed the memory block but already added > the memory block to the group list, not good. Let's defer adding the > block to the memory group to after registering the memory block device. > > We do handle it properly during unregister_memory(), but that's not > called when the registration fails. > > Fixes: 028fc57a1c36 ("drivers/base/memory: introduce "memory groups" to logically group memory blocks") > Cc: stable@vger.kernel.org # v5.15+ > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Oscar Salvador > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs