From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DECC433EF for ; Fri, 28 Jan 2022 17:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C17E56B0114; Fri, 28 Jan 2022 12:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC69D6B0116; Fri, 28 Jan 2022 12:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADCA06B0117; Fri, 28 Jan 2022 12:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 9F8CB6B0114 for ; Fri, 28 Jan 2022 12:38:46 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5D54782913F4 for ; Fri, 28 Jan 2022 17:38:46 +0000 (UTC) X-FDA: 79080405852.22.ED14C9B Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by imf13.hostedemail.com (Postfix) with ESMTP id 8DB302001D for ; Fri, 28 Jan 2022 17:38:45 +0000 (UTC) Received: by gofer.mess.org (Postfix, from userid 1000) id C7E2F10008F; Fri, 28 Jan 2022 17:38:43 +0000 (UTC) Date: Fri, 28 Jan 2022 17:38:43 +0000 From: Sean Young To: Shuah Khan Cc: Alexei Starovoitov , kernel test robot , Alexei Starovoitov , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail Message-ID: References: <20220128075346.GG8421@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8DB302001D X-Rspam-User: nil Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of sean@mess.org designates 88.97.38.141 as permitted sender) smtp.mailfrom=sean@mess.org X-Stat-Signature: wywwrwkkoba9dzrnu96yohxqnxtwkqqg X-HE-Tag: 1643391525-346869 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000351, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 10:27:52AM -0700, Shuah Khan wrote: > On 1/28/22 9:49 AM, Alexei Starovoitov wrote: > > On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: > > >=20 >=20 > > > > ir_loopback.c: In function =E2=80=98main=E2=80=99: > > > > ir_loopback.c:147:20: error: =E2=80=98RC_PROTO_RCMM32=E2=80=99 un= declared (first use in this function); did you mean =E2=80=98RC_PROTO_RC6= _MCE=E2=80=99? > > > > if (rc_proto =3D=3D RC_PROTO_RCMM32 && > > > > ^~~~~~~~~~~~~~~ > > > > RC_PROTO_RC6_MCE > > >=20 > > > So this commit removes the copy of lirc.h from tools/include/uapi/l= inux/lirc.h, > > > so now the test uses /usr/include/linux/lirc.h. It appears that thi= s file > > > does not have RC_PROTO_RCMM32 defined on this system, which means i= t is a > > > kernel header from v5.1 or earlier (this was added in commit > > > 721074b03411327e7bf41555d4cc7c18f49313f7). > > >=20 > > > It looks like this machine is redhat 8.3, which ships with kernel 4= .18. > > >=20 > > > I guess my change was far too optimistic; I had no ideal enterprise= kernels > > > were so ancient. > > >=20 > > > We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. S= orry about > > > the turbulence. > >=20 > > I'd rather avoid reverting. > > Just add ifdef or something to shut up the error on old distros. > >=20 >=20 > Sean, >=20 > Let's not add release checks. >=20 > Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define > just that one in ir_loopback.c with a comment that it can be removed. >=20 > ifndef RC_PROTO_RCMM32 --- Hi Shuah, I was thinking along the same lines, however RC_PROTO_RCMM32 is an enum value so a pre-processor #ifdef is not going to work. At the moment I hav= en't had any bright ideas other than doing a `#define RC_PROTO_RCMM32 26` at t= he top of the file. Open to suggestions. Thanks, Sean