From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B10BC433FE for ; Fri, 28 Jan 2022 12:23:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB0616B0071; Fri, 28 Jan 2022 07:23:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5FAE6B0072; Fri, 28 Jan 2022 07:23:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4E4D6B0073; Fri, 28 Jan 2022 07:23:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id C8C296B0071 for ; Fri, 28 Jan 2022 07:23:36 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7E0A295195 for ; Fri, 28 Jan 2022 12:23:36 +0000 (UTC) X-FDA: 79079611632.18.AE416FF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id EA4AD20003 for ; Fri, 28 Jan 2022 12:23:35 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A06F6212B7; Fri, 28 Jan 2022 12:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1643372614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=71M7m26qjEQDHZgi5jO+0z+MJXrkQnj7Uc4OCh8cPbY=; b=jKX1hcm5THaAqw3fk9koUnFPbf1DYWasC685eJ5k5OmZpCbFLvlcaLCbf83tGypVN+PQPf 1lBWi/fxa9b4MBjz9Zsj4lJo8i1+Epa6tRyCCCBdoO4O13ti4AF2orK4JCDkQP7FOJAFX+ LOz7q195Ybp6GNUnke98QQCR3WBY0wU= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 70006A3B83; Fri, 28 Jan 2022 12:23:34 +0000 (UTC) Date: Fri, 28 Jan 2022 13:23:33 +0100 From: Michal Hocko To: Shakeel Butt Cc: Vasily Averin , Johannes Weiner , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: replace in_interrupt() with !in_task() Message-ID: References: <20220127162636.3461256-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127162636.3461256-1-shakeelb@google.com> Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=jKX1hcm5; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: nil X-Rspamd-Queue-Id: EA4AD20003 X-Stat-Signature: i6y8gu4oh5hy6zapb1tp3qnpd4dmizhj X-Rspamd-Server: rspam12 X-HE-Tag: 1643372615-564619 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 27-01-22 08:26:36, Shakeel Butt wrote: > Replace the deprecated in_interrupt() with !in_task() because > in_interrupt() returns true for BH disabled even if the call happens in > the task context. in_task() is the right interface to differentiate > task context from NMI, hard IRQ and softirq contexts. Makes sense. I do not think this will have any visible effect. Except for removing a deprecated call, right? > Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d067366002e6..215dfe325e9d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2688,7 +2688,7 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, > READ_ONCE(memcg->swap.high); > > /* Don't bother a random interrupted task */ > - if (in_interrupt()) { > + if (!in_task()) { > if (mem_high) { > schedule_work(&memcg->high_work); > break; > @@ -6968,7 +6968,7 @@ void mem_cgroup_sk_alloc(struct sock *sk) > return; > > /* Do not associate the sock with unrelated interrupted task's memcg. */ > - if (in_interrupt()) > + if (!in_task()) > return; > > rcu_read_lock(); > -- > 2.35.0.rc0.227.g00780c9af4-goog -- Michal Hocko SUSE Labs