From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B50AC433EF for ; Fri, 28 Jan 2022 08:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B312A6B0071; Fri, 28 Jan 2022 03:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE1246B0072; Fri, 28 Jan 2022 03:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9036B0073; Fri, 28 Jan 2022 03:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 8CA196B0071 for ; Fri, 28 Jan 2022 03:53:26 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4392A181DA55E for ; Fri, 28 Jan 2022 08:53:26 +0000 (UTC) X-FDA: 79079082012.24.1B4EB09 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id D49E020002 for ; Fri, 28 Jan 2022 08:53:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643360005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ui+9um5xfQ0oHtLsJggPNkOjXF3dvpzwJbYCtfSP3w=; b=H7pBSaHxbooCxY/Ej6pJF60i3739CZ9fRngY8j4NCuiIBmutd2UPtP1bxyoMVyhS795m1M FtZNx+JllRUiWd0n/vmWyvHpBGybX+c+Og0ZkR26yrvtW2tp6tFdV8Pib74pTnPny7EmkY cBKADWUwoYQ4l+h/ZizNmjhesWTSHtc= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-222-pNn9cNR9O5uigOFXlPlFSw-1; Fri, 28 Jan 2022 03:53:24 -0500 X-MC-Unique: pNn9cNR9O5uigOFXlPlFSw-1 Received: by mail-pg1-f199.google.com with SMTP id n6-20020a63b446000000b0034c0280aa73so3046803pgu.15 for ; Fri, 28 Jan 2022 00:53:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1ui+9um5xfQ0oHtLsJggPNkOjXF3dvpzwJbYCtfSP3w=; b=bkzbLhbeQk0kno9Kl3OcJTw7z6PvhVrt/jU8Jhz5z36nevIwsoN/GqHpq0p20FbaAn lyoW/PJNrw863xnYHnmPzy10nHCGPraejWqN7HQfpsDCYcBp4Ds0Ce1HIcXO+TwmfUyf dwmcf+K634ijXVt2bNIqBMUefaW/DPrjnpzkkBDqTmFL3kw4tS3ntFaf1ir5Uketdzvw 4TWhwosyiTnTDJNZ29w94L3T3cFmvZWZ08iqnuR8R6DPxyYFeUSzU8abHwvqTi2eUd0m DGCyT7KdqMX/d1AT48lFb/kO3vdOutVQ0II6wv88Lk6Gb0VzIxgEFXYEQzQsRU8Grc39 SzZg== X-Gm-Message-State: AOAM532bOA4s3XJrJofkjI9qUUyWdflKd+ktpPa0I4nIX7wj/EfptxNx 8nQoYd1oaT4KCQtZ1vKSAXiKpYnlfrJWtIPwz1H6gTnjjPXMMYbvsmfbxJlfzml1UL/05rCDx3s 0NVNgAM95Uz8= X-Received: by 2002:a63:d503:: with SMTP id c3mr5901442pgg.159.1643360002957; Fri, 28 Jan 2022 00:53:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxu2JzxEwlkerHoOsLf2Vu4nsUK8VZ/RXYifDboeZnYi1KRcw8RePI89Nq5PXGEO9KbiLZ2rg== X-Received: by 2002:a63:d503:: with SMTP id c3mr5901415pgg.159.1643360002581; Fri, 28 Jan 2022 00:53:22 -0800 (PST) Received: from xz-m1.local ([94.177.118.75]) by smtp.gmail.com with ESMTPSA id bf23sm1651107pjb.52.2022.01.28.00.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 00:53:22 -0800 (PST) Date: Fri, 28 Jan 2022 16:53:15 +0800 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alistair Popple , Andrew Morton , Andrea Arcangeli , Matthew Wilcox , John Hubbard , Hugh Dickins , Vlastimil Babka , Yang Shi , "Kirill A . Shutemov" Subject: Re: [PATCH v3 2/4] mm: Rename zap_skip_check_mapping() to should_zap_page() Message-ID: References: <20220128045412.18695-1-peterx@redhat.com> <20220128045412.18695-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: dzbn4wqadsh38fu93gp74tkg9stzchmo X-Rspam-User: nil Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H7pBSaHx; spf=none (imf31.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D49E020002 X-HE-Tag: 1643360005-60574 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 09:16:07AM +0100, David Hildenbrand wrote: > On 28.01.22 05:54, Peter Xu wrote: > > The previous name is against the natural way people think. Invert the meaning > > and also the return value. No functional change intended. > > > > Suggested-by: Hugh Dickins > > Could have sworn it was me :P Yeah it's possible. :) I'll add both of you in the next version if there is. > > > Signed-off-by: Peter Xu > > --- > > Reviewed-by: David Hildenbrand Thanks, -- Peter Xu