From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8831C433F5 for ; Thu, 27 Jan 2022 14:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 108706B0095; Thu, 27 Jan 2022 09:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B80D6B009A; Thu, 27 Jan 2022 09:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE8C76B009B; Thu, 27 Jan 2022 09:45:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id E02FC6B0095 for ; Thu, 27 Jan 2022 09:45:32 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 90012181E995A for ; Thu, 27 Jan 2022 14:45:32 +0000 (UTC) X-FDA: 79076340504.30.686B716 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id 2A5A62000B for ; Thu, 27 Jan 2022 14:45:32 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 280AC1F385; Thu, 27 Jan 2022 14:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1643294731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RcGkJCsMOxm3HKvLbnVc+nUcQAOUfO3nUHEQ2pC0eLY=; b=sbHrglxbbiD3Rv19cqAeVKqDVBqm7Kk+OThabUA+8TJBrTrYsAZJ4ZXb+W1dCEbS0ufskg u4ye3envSo3ZHt9dSqcbL7cEgIEN2wsPsN7RfS+Vuv1ofQeK9V+pH6m3v2AtK9rDbPtul2 RmsG5RoumVr/ej4tMWdJsLmPCDHGrbQ= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EC2A6A3B85; Thu, 27 Jan 2022 14:45:30 +0000 (UTC) Date: Thu, 27 Jan 2022 15:45:30 +0100 From: Michal Hocko To: Mike Rapoport Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini Subject: Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization Message-ID: References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-5-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2A5A62000B X-Rspam-User: nil Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sbHrglxb; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Stat-Signature: 4ddarfzp3gk5hr8jbqh4jtmysdmmjztu X-Rspamd-Server: rspam08 X-HE-Tag: 1643294732-742242 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 27-01-22 15:39:55, Mike Rapoport wrote: > On Thu, Jan 27, 2022 at 09:53:03AM +0100, Michal Hocko wrote: [...] > > + pgdat->nr_zones = 0; > > + pgdat->kswapd_order = 0; > > + pgdat->kswapd_highest_zoneidx = 0; > > + pgdat->node_start_pfn = 0; > > + for_each_online_cpu(cpu) { > > + struct per_cpu_nodestat *p; > > + > > + p = per_cpu_ptr(pgdat->per_cpu_nodestats, cpu); > > + memset(p, 0, sizeof(*p)); > > + } > > It seems to me that most of this is already done by free_area_init_node() > at boot time anyway. Do I miss something? As already replied to David I really didn't want to change the existing logic. -- Michal Hocko SUSE Labs