From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B2E1C433EF for ; Thu, 27 Jan 2022 13:34:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32EAC6B0071; Thu, 27 Jan 2022 08:34:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DE466B0072; Thu, 27 Jan 2022 08:34:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CD916B0073; Thu, 27 Jan 2022 08:34:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by kanga.kvack.org (Postfix) with ESMTP id 0D0AE6B0071 for ; Thu, 27 Jan 2022 08:34:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BC31F21EBC for ; Thu, 27 Jan 2022 13:34:43 +0000 (UTC) X-FDA: 79076162046.01.3979E74 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 150CD8000E for ; Thu, 27 Jan 2022 13:34:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D63D761BC5; Thu, 27 Jan 2022 13:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF10C340E4; Thu, 27 Jan 2022 13:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643290481; bh=fd4J3Q09HA3HgoqBjZYSLSYqtMJ9HcItVk5HZwKUFBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WSPjF8La1fKzn3JBxHgUq74VUI66bXY5zHZU4m8RrxbLYFUsE2i1D8UtQiE1y0w8w LzW/HL7tZqVS8oyvs7b/QYhVL4mAiq9DIDPEcb1eiP/7lDCvqGaLKmAlqUP9TR+Jvk BvuOKa4yOK/Iaf/sGMAD9uScehLzNnHG3oSOAbQoaMUIUcR375WMgZWS28ubHqE7U1 vMUunrXFCT/P7LD2LwpuZTVs6xykNh9BT2Ro9ftBflO7J6lHtnoaptqOcBMhJVPlKf R9K/KOyJ5r4ATO1zf6GN0PnyPTmx7bUb2BUytu5QZ05avLo6KVcZPKdI1NitIyqX++ CCHy1/GDVQmOw== Date: Thu, 27 Jan 2022 15:34:32 +0200 From: Mike Rapoport To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini , Michal Hocko Subject: Re: [PATCH 5/6] mm: make free_area_init_node aware of memory less nodes Message-ID: References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-6-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127085305.20890-6-mhocko@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 150CD8000E X-Stat-Signature: utnc1pu5esg1gf1z8jdh9nskcch58mn8 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WSPjF8La; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspam-User: nil X-HE-Tag: 1643290482-154644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 09:53:04AM +0100, Michal Hocko wrote: > From: Michal Hocko > > free_area_init_node is also called from memory less node initialization > path (free_area_init_memoryless_node). It doesn't really make much sense > to display the physical memory range for those nodes: > Initmem setup node XX [mem 0x0000000000000000-0x0000000000000000] > > Instead be explicit that the node is memoryless: > Initmem setup node XX as memoryless > > Acked-by: Rafael Aquini > Signed-off-by: Michal Hocko Reviewed-by: Mike Rapoport > --- > mm/page_alloc.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 32d0189de4c5..83da2279be72 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7682,9 +7682,14 @@ static void __init free_area_init_node(int nid) > pgdat->node_start_pfn = start_pfn; > pgdat->per_cpu_nodestats = NULL; > > - pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, > - (u64)start_pfn << PAGE_SHIFT, > - end_pfn ? ((u64)end_pfn << PAGE_SHIFT) - 1 : 0); > + if (start_pfn != end_pfn) { > + pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, > + (u64)start_pfn << PAGE_SHIFT, > + end_pfn ? ((u64)end_pfn << PAGE_SHIFT) - 1 : 0); > + } else { > + pr_info("Initmem setup node %d as memoryless\n", nid); > + } > + > calculate_node_totalpages(pgdat, start_pfn, end_pfn); > > alloc_node_mem_map(pgdat); > -- > 2.30.2 > -- Sincerely yours, Mike.