From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6D9C433F5 for ; Thu, 27 Jan 2022 12:45:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F00326B0072; Thu, 27 Jan 2022 07:45:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E88076B0073; Thu, 27 Jan 2022 07:45:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D77906B0075; Thu, 27 Jan 2022 07:45:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id CA1686B0072 for ; Thu, 27 Jan 2022 07:45:16 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7ED3B91E3F for ; Thu, 27 Jan 2022 12:45:16 +0000 (UTC) X-FDA: 79076037432.12.A4BB0A6 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 04D3AC0021 for ; Thu, 27 Jan 2022 12:45:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5C25B819C2; Thu, 27 Jan 2022 12:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA8D0C340E4; Thu, 27 Jan 2022 12:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643287513; bh=tRHvbXNSxItnFTyKgs26qFkni8IsT7iEbBg+SJZGGtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F0E4M1pv9O4k1l6/PZTuB5T+BWLo19uArHpzNftT87yOsH7fHi3w89beb+RZXBbJ1 ZrXflNk5fNQpD5+qGwkNYuGwqfkajsV6es0tHrzjgc1PSSPql8aZXS27Ro6a3ycsvk 3rYVm9GSMfS+z5VLZC/B4ZnOLKkODms8KG+zlMcR2JttMEGMXMl+Pab31qo5v2ZTZF aIns+8PFMmb0XnO7ggwyI+1AVgGcc9e8yT9zjrt7+s1GUVN9s0NGUFRCGhTc8AhWof JwTwTtu3V0i4IVUOQdrdgsTIODgf9JtTcbaYDFlVvOi7yQoyfPC+afnymAHZ20COkt m1IBXulbPT1Zg== Date: Thu, 27 Jan 2022 14:45:06 +0200 From: Mike Rapoport To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/sparse: make mminit_validate_memmodel_limits() static Message-ID: References: <20220127093221.63524-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127093221.63524-1-linmiaohe@huawei.com> X-Stat-Signature: qd8o49z8stmdxjtyncfw7wcx56jn3y3c X-Rspam-User: nil Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F0E4M1pv; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 04D3AC0021 X-HE-Tag: 1643287515-328699 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 05:32:21PM +0800, Miaohe Lin wrote: > It's only used in the sparse.c now. So we can make it static and further > clean up the relevant code. > > Signed-off-by: Miaohe Lin Reviewed-by: Mike Rapoport > --- > mm/internal.h | 11 ----------- > mm/sparse.c | 2 +- > 2 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 4c2d06a2f50b..927dfba5111f 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -572,17 +572,6 @@ static inline void mminit_verify_zonelist(void) > } > #endif /* CONFIG_DEBUG_MEMORY_INIT */ > > -/* mminit_validate_memmodel_limits is independent of CONFIG_DEBUG_MEMORY_INIT */ > -#if defined(CONFIG_SPARSEMEM) > -extern void mminit_validate_memmodel_limits(unsigned long *start_pfn, > - unsigned long *end_pfn); > -#else > -static inline void mminit_validate_memmodel_limits(unsigned long *start_pfn, > - unsigned long *end_pfn) > -{ > -} > -#endif /* CONFIG_SPARSEMEM */ > - > #define NODE_RECLAIM_NOSCAN -2 > #define NODE_RECLAIM_FULL -1 > #define NODE_RECLAIM_SOME 0 > diff --git a/mm/sparse.c b/mm/sparse.c > index d21c6e5910d0..952f06d8f373 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -126,7 +126,7 @@ static inline int sparse_early_nid(struct mem_section *section) > } > > /* Validate the physical addressing limitations of the model */ > -void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn, > +static void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn, > unsigned long *end_pfn) > { > unsigned long max_sparsemem_pfn = 1UL << (MAX_PHYSMEM_BITS-PAGE_SHIFT); > -- > 2.23.0 > > -- Sincerely yours, Mike.