From: Matthew Wilcox <willy@infradead.org>
To: Charan Teja Kalla <quic_charante@quicinc.com>
Cc: Mark Hemment <markhemm@googlemail.com>,
hughd@google.com, Andrew Morton <akpm@linux-foundation.org>,
vbabka@suse.cz, rientjes@google.com, mhocko@suse.com,
surenb@google.com, shakeelb@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Charan Teja Reddy <charante@codeaurora.org>
Subject: Re: [PATCH v3 RESEND] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem
Date: Tue, 18 Jan 2022 13:27:37 +0000 [thread overview]
Message-ID: <YebASTShsELnoiVj@casper.infradead.org> (raw)
In-Reply-To: <a31bdd1a-0fd8-7303-dc97-a2cf156f1d83@quicinc.com>
On Tue, Jan 18, 2022 at 05:05:40PM +0530, Charan Teja Kalla wrote:
> Hello Matthew,
>
> > Yes. This should obviously be an xa_for_each() loop.
>
> In one of your patch[1], where we used xarray iterator, though most of
> the entries found requires to call xas_pause() but still endup in using
> xas_for_each() rather than xa_for_each(). Then, Should this code be
> changed to use xa_for_each()? The documentation also says that "The
> xas_for_each() iterator will expand into more inline code than
> xa_for_each()."
>
> [1]https://patchwork.kernel.org/project/linux-mm/patch/20200819184850.24779-4-willy@infradead.org/
How do you know the distribution of swap and non-swap entries in that
region of that xarray?
next prev parent reply other threads:[~2022-01-18 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 17:05 Charan Teja Reddy
2022-01-07 12:10 ` Mark Hemment
2022-01-10 10:21 ` Charan Teja Kalla
2022-01-12 8:21 ` Charan Teja Kalla
2022-01-12 11:34 ` Mark Hemment
2022-01-12 13:19 ` Matthew Wilcox
2022-01-12 13:35 ` Charan Teja Kalla
2022-01-18 11:35 ` Charan Teja Kalla
2022-01-18 13:27 ` Matthew Wilcox [this message]
2022-01-10 12:36 ` Mark Hemment
2022-01-10 15:14 ` Charan Teja Kalla
2022-01-12 11:38 ` Mark Hemment
2022-01-12 15:43 ` Charan Teja Kalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YebASTShsELnoiVj@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markhemm@googlemail.com \
--cc=mhocko@suse.com \
--cc=quic_charante@quicinc.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox