From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5C8C433EF for ; Mon, 17 Jan 2022 16:11:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7676B0073; Mon, 17 Jan 2022 11:11:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 997D46B0074; Mon, 17 Jan 2022 11:11:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8871B6B0075; Mon, 17 Jan 2022 11:11:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 775EC6B0073 for ; Mon, 17 Jan 2022 11:11:52 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 319F792EB8 for ; Mon, 17 Jan 2022 16:11:52 +0000 (UTC) X-FDA: 79040270064.28.06A2DFE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id E1E35180003 for ; Mon, 17 Jan 2022 16:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fB/5UIJYK/N6mY41Lc7aoPYq98s1VP7KunDWS2lUCAs=; b=HmIb80JJAC7ZddUBJ1hJaFr52I EMGYIKArwetQ6GXfbsQq4iRVshjxPMN8mbV7Qg/hc0tBPSAe8O1YCbCyoFUaqfNmT8ZbRZFB0AV5Q 8q8TfhXjqILYLu8YC0b0BvatQ1aMJb39zGa1oWZltF0gtVgtnTf3ior8bN+lqFWqw3arwT1Fgx6BN gM1ZeOy0LNFItTVRLAEyVi2Cbu8ETZqkUYcao7lnF4Q5hk98dR4HpC3lE4lGazYUdd0sql0qWP5oi 6GBceqNur6eMvTR3V1JQnPqZnjnKUmqY+gjI8B3NiCCl9dZJYO3L5IlHAl085LJOqzgm5N6sMZHUF rw/N/iDA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9Ubk-008Mko-Ug; Mon, 17 Jan 2022 16:11:49 +0000 Date: Mon, 17 Jan 2022 16:11:48 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 02/12] filemap: Use folio_put_refs() in filemap_free_folio() Message-ID: References: <20220116121822.1727633-1-willy@infradead.org> <20220116121822.1727633-3-willy@infradead.org> <20220117155641.u5ysambg72nq2p6y@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220117155641.u5ysambg72nq2p6y@box.shutemov.name> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E1E35180003 X-Stat-Signature: szfj73yde31aci7eqmhtecjfnr9k3h8p Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HmIb80JJ; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1642435911-230059 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 17, 2022 at 06:56:41PM +0300, Kirill A. Shutemov wrote: > On Sun, Jan 16, 2022 at 12:18:12PM +0000, Matthew Wilcox (Oracle) wrote: > > + if (folio_test_large(folio) && !folio_test_hugetlb(folio)) > > + refs = folio_nr_pages(folio); > > Isn't folio_test_large() check redundant? folio_nr_pages() would return 1 > for non-large folio, wouldn't it? I'm trying to avoid the function call for !hugetlb pages.