From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952B3C433F5 for ; Fri, 14 Jan 2022 11:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D5CB6B0072; Fri, 14 Jan 2022 06:08:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 185F36B0073; Fri, 14 Jan 2022 06:08:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C9C6B0074; Fri, 14 Jan 2022 06:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id F07766B0072 for ; Fri, 14 Jan 2022 06:08:37 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A208991ABB for ; Fri, 14 Jan 2022 11:08:37 +0000 (UTC) X-FDA: 79028619474.30.0B780D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 495014001D for ; Fri, 14 Jan 2022 11:08:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FC6161EF1; Fri, 14 Jan 2022 11:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 233C3C36AE5; Fri, 14 Jan 2022 11:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642158516; bh=OF5OUUAm25dp5cp+JT0GiuvYGOwzKMtdyhATZeQWCM4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=anWYlmeAreoucUVCTnYlq5eLjpIWYUu97Eer6MAZxeInCL2iyNeuvzdkr4wXTCilh ADbkMRQOsbDKfGrQhI/Krb3R7WFGc/QG6nzEmEKa0alTS2JpzXrfMo3TEZhlLl22fu O/XvQqtC6HrkjNYMciuW/e+EteHpY6ZAvt5AX88lFtxPpWvzn6Pcd5BkA/Buu0SDru e1xE+5quxorgWd+xmEB8LlUeq1b3EJ600qkDwcuSgR9Ly/WxVGoAduHQwChY7NaAx+ 0Dtj5KrkdTYWGk26kAp8EQbFDtPRuo2/rBAFXH4k8BrxHPAgx19pRBUIhVExEPYznV 2326WkH6r4Fng== Date: Fri, 14 Jan 2022 13:08:28 +0200 From: Mike Rapoport To: Wei Yang Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on allocation Message-ID: References: <20220111010302.8864-1-richard.weiyang@gmail.com> <20220111010302.8864-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111010302.8864-2-richard.weiyang@gmail.com> X-Stat-Signature: hcnncw6wbtebkggaa3ne1xwfd9qkq945 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=anWYlmeA; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 495014001D X-HE-Tag: 1642158517-90023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote: > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang Reviewed-by: Mike Rapoport > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 11715f7323c0..a504616f904a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > } > > lruvec_init(&pn->lruvec); > - pn->usage_in_excess = 0; > - pn->on_tree = false; > pn->memcg = memcg; > > memcg->nodeinfo[node] = pn; > -- > 2.33.1 > > -- Sincerely yours, Mike.