From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 557A7C4332F for ; Thu, 13 Jan 2022 23:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9E86B0072; Thu, 13 Jan 2022 18:02:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99A616B0073; Thu, 13 Jan 2022 18:02:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83C7F6B0074; Thu, 13 Jan 2022 18:02:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 730766B0072 for ; Thu, 13 Jan 2022 18:02:22 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 28146181DF756 for ; Thu, 13 Jan 2022 23:02:22 +0000 (UTC) X-FDA: 79026789324.23.57B4EC7 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf14.hostedemail.com (Postfix) with ESMTP id E1273100010 for ; Thu, 13 Jan 2022 23:02:20 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id v6so10421608iom.6 for ; Thu, 13 Jan 2022 15:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5pDJzk1dQsu0Qk8opYITEZv6dz4zcJdUZeTWjVZhptE=; b=i7ChxMb5M3oaC8H54OCxVrXkfUa7WLgJX+ltnKBKDBkjz66N9TQzyDZinEbP79ixk3 tjxIfvWEOm33MpTaaKvOx4EL+geVEPBg41GOv1jJcsOf82ZVYdqOCCMbuTEYc63fpvWM Fa5uXRS0je7t11ma8khJr08jVW6zsrFZPFOlVJy2ygnz1T9ihu4jgB6FGN0sRF5G6yCi fd2qj4c8tGnOxXO3bE7g56BWoJt0S9gFYxFLez/ONgOdsBCLZlZ4/yxZSx7FztJNAFH/ QMQJIUw/J5MakijV5N5CuCnnJiT803PyaWh1w/qzi76wpuAMLwvKkYffhOfO/RUxjjJB 1kOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5pDJzk1dQsu0Qk8opYITEZv6dz4zcJdUZeTWjVZhptE=; b=oafsV397Lf0MN0dRljhTkz24wcymiZ/kZ/W9Rp3Vj4Nw8jWRVIKc/qfMjqGglsfCSv b9v3RWNhulvrRAXUrZAljxJpqNIBPTqAKDWFB9U6zSylURnUJkJMX7/wJhB2nYmLbOAI zp8sIq9HqWSGxhtUCpbj0D/RWBhJ/ZYmqd07pMDtUCpCIXcHJWJEg+kzzQeciKjyYtv/ 2z9HvEpHL8khUZMh/hdkd34PPAfCgEaiuVZRoDu3fgJCj0ZYUVPUcMmbd5YGM++1yJrz mD+sAoydJdVsnW4IOcfp+2ItnKsd/OW6XLFTc3i69mAz9fVTbP4yEOKP+O6147J/bzGR 45LQ== X-Gm-Message-State: AOAM532koFO3eHRnJNywofkaOXhxUjHCD2l0oHF7ENT8kS/yxGbzxUfc iCh5AGuliVlnFcW5K9lCnurPWQ== X-Google-Smtp-Source: ABdhPJzMMAQXbahgizkqdtfjZ2i9Fvd2grW2x1BACOTg5wkyiMKd17pDOdTjWFpfP/ndoI6nBLGJew== X-Received: by 2002:a02:a982:: with SMTP id q2mr3158600jam.220.1642114939372; Thu, 13 Jan 2022 15:02:19 -0800 (PST) Received: from google.com ([2620:15c:183:200:2ee3:2c3c:a8c8:b1bf]) by smtp.gmail.com with ESMTPSA id i20sm3830279iov.43.2022.01.13.15.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 15:02:18 -0800 (PST) Date: Thu, 13 Jan 2022 16:02:15 -0700 From: Yu Zhao To: "Aneesh Kumar K.V" Cc: Andrew Morton , Linus Torvalds , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Konstantin Kharlamov Subject: Re: [PATCH v6 8/9] mm: multigenerational lru: user interface Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> <20220104202227.2903605-9-yuzhao@google.com> <87a6g0nczg.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6g0nczg.fsf@linux.ibm.com> X-Stat-Signature: mc8rzp89mmkfnh9o8m5rezkj7oou93kk Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=i7ChxMb5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E1273100010 X-HE-Tag: 1642114940-157680 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 13, 2022 at 04:01:31PM +0530, Aneesh Kumar K.V wrote: > Yu Zhao writes: > > > Add /sys/kernel/mm/lru_gen/enabled as a runtime kill switch. > > > Got the below lockdep warning while using the above kill/enable switch > > > [ 84.252952] ====================================================== > [ 84.253012] WARNING: possible circular locking dependency detected > [ 84.253074] 5.16.0-rc8-16204-g1cdcf1120b31 #511 Not tainted > [ 84.253135] ------------------------------------------------------ > [ 84.253194] bash/2862 is trying to acquire lock: > [ 84.253243] c0000000021ff740 (cgroup_mutex){+.+.}-{3:3}, at: store_enable+0x80/0x1510 > [ 84.253340] > but task is already holding lock: > [ 84.253410] c000000002221348 (mem_hotplug_lock){++++}-{0:0}, at: mem_hotplug_begin+0x30/0x50 > [ 84.253503] > which lock already depends on the new lock. > > [ 84.255933] Chain exists of: > cgroup_mutex --> cpu_hotplug_lock --> mem_hotplug_lock Thanks. Will reverse the order between mem_hotplug_lock and cgroup_mutex in the next spin.