From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92DE7C433EF for ; Mon, 10 Jan 2022 17:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1B46B0071; Mon, 10 Jan 2022 12:21:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24F996B0072; Mon, 10 Jan 2022 12:21:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F1196B0074; Mon, 10 Jan 2022 12:21:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 01A066B0071 for ; Mon, 10 Jan 2022 12:21:30 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A539783C48 for ; Mon, 10 Jan 2022 17:21:30 +0000 (UTC) X-FDA: 79015043940.22.1173BBF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 237F920012 for ; Mon, 10 Jan 2022 17:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641835289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VY56dbPaHLn3Z7C1nmGwXuOUHWMWAItdJjqmaXqDacs=; b=FuNGJwBYLPDS0oZaUsfs6upbYnf1xnDG6mBvbHAv4AhPxWlHDYucoB7ROfE1VA5+oTGm4j dm6f8kJQUOILLpWkdTXfCxLBlYARTs10rBL2LEHgNt3ktVP23xi6mENZtvVWvx4Mh0wt78 MSV3cLlb0YWKIeveDyjimvALDRvwoho= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-511-i1lhT65kNBKi3k6NBzoxiQ-1; Mon, 10 Jan 2022 12:21:28 -0500 X-MC-Unique: i1lhT65kNBKi3k6NBzoxiQ-1 Received: by mail-oo1-f69.google.com with SMTP id a7-20020a4ad5c7000000b002dacfc3d40cso8873415oot.9 for ; Mon, 10 Jan 2022 09:21:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VY56dbPaHLn3Z7C1nmGwXuOUHWMWAItdJjqmaXqDacs=; b=q4Mb876tDk2Be8epi4qpVdXG+hzlh4/KoeNtwMW46mDZoLwy9J0kKvOJ3xBjOJ7Tz0 sRxXXB0AhGOx0S5+p6d0bMyPQ256aqgqVMRNJG/N3EXqyWYXO8HCWOii96pt8tME2n7t FUqaWiRWmV3iIA7GbjwETnJzNPUW3D3R0egU4P6yoyR5yMg5yw32kOg420FTF+BpzmTh aH2bctDE21DXRx+oKjswHpazyYULBSilqZVnlx1mOnH/ts9CAkJXvvSru514NvbDIcp+ 3tKk3YjpIcJ9Gq40RPbWKpEQpNwNotkFaeexSAqgEjUHYQG1vyuLes+msvEZ/6vFEfCs Pm3g== X-Gm-Message-State: AOAM530LmL+WjjDknW+kqIutprr6huzm24Gz/+T6Yu3iX1lv3rHm6RUu dGNZWBXoRt9eGN96I2zR5gQ+948bqlV0gbQTGQdTFGVB/daeP6b7yrftDn4A8FbVvCfWk6EYCEh 6WUaTtzmobnc= X-Received: by 2002:a9d:be9:: with SMTP id 96mr562138oth.211.1641835287691; Mon, 10 Jan 2022 09:21:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJy019bkdJ2xfFGTi9iDs1JrhWEMoVF7t0UebvqVLd/zmC9dnJ9ZxOEHSsDWfxamc2lxl3cjcA== X-Received: by 2002:a9d:be9:: with SMTP id 96mr562123oth.211.1641835287545; Mon, 10 Jan 2022 09:21:27 -0800 (PST) Received: from optiplex-fbsd (c-73-182-255-193.hsd1.nh.comcast.net. [73.182.255.193]) by smtp.gmail.com with ESMTPSA id w13sm1253817oic.24.2022.01.10.09.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 09:21:27 -0800 (PST) Date: Mon, 10 Jan 2022 12:21:24 -0500 From: Rafael Aquini To: Michal Hocko Cc: Yang Shi , Andrew Morton , Nico Pache , Linux Kernel Mailing List , Linux MM , Shakeel Butt , Kirill Tkhai , Roman Gushchin , Vlastimil Babka , Vladimir Davydov , raquini@redhat.com, David Hildenbrand Subject: Re: [PATCH v2 1/1] mm/vmscan.c: Prevent allocating shrinker_info on offlined nodes Message-ID: References: <20211207224013.880775-1-npache@redhat.com> <20211207224013.880775-2-npache@redhat.com> <20211207154438.c1e49a3f0b5ebc9245aac61b@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FuNGJwBY; spf=none (imf03.hostedemail.com: domain of aquini@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=aquini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 237F920012 X-Stat-Signature: x87y3uyemdjywdwdcgy6rikio8pxsnzy X-HE-Tag: 1641835289-566873 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 06:16:23PM +0100, Michal Hocko wrote: > On Mon 10-01-22 12:09:50, Rafael Aquini wrote: > [...] > > > 3. From David, fix in node_zonelist(). > > > https://lore.kernel.org/all/51c65635-1dae-6ba4-daf9-db9df0ec35d8@redhat.com/T/#u > > > > It seems to me that (3) is the simplest and effective way to cope with this case > > Did you have chance to look at http://lkml.kernel.org/r/20211214100732.26335-1-mhocko@kernel.org I'll take a closer look at it. Thanks Michal. -- Rafael