From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F42CC433EF for ; Mon, 10 Jan 2022 17:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 148416B0072; Mon, 10 Jan 2022 12:16:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F70F6B0074; Mon, 10 Jan 2022 12:16:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F00AF6B0075; Mon, 10 Jan 2022 12:16:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id E45536B0072 for ; Mon, 10 Jan 2022 12:16:25 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ABDAC8248D52 for ; Mon, 10 Jan 2022 17:16:25 +0000 (UTC) X-FDA: 79015031130.09.FA8BB0B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id 2888C12000B for ; Mon, 10 Jan 2022 17:16:25 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 24C861F383; Mon, 10 Jan 2022 17:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1641834984; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oN2vqgjVFm/26Gh3w73e9Is5BclOGZvV0sUgskRJvn8=; b=shW1fHmBupnyKBH5DVkrV83LpzoNNgLvcuyeggybA63qr9NKSJpJWwmpvCPxaWx7RvzHrB Sd7DD0ODdHpzrn6+MT7V9uRPMxmr0ewF6ygl4bh7dH4ln6vj/7tszzIJl7CrE4Dk3SfF2v H4oEX2feIg8y3vpaqw/kslS6rWUgkBs= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DCC4BA3B87; Mon, 10 Jan 2022 17:16:23 +0000 (UTC) Date: Mon, 10 Jan 2022 18:16:23 +0100 From: Michal Hocko To: Rafael Aquini Cc: Yang Shi , Andrew Morton , Nico Pache , Linux Kernel Mailing List , Linux MM , Shakeel Butt , Kirill Tkhai , Roman Gushchin , Vlastimil Babka , Vladimir Davydov , raquini@redhat.com, David Hildenbrand Subject: Re: [PATCH v2 1/1] mm/vmscan.c: Prevent allocating shrinker_info on offlined nodes Message-ID: References: <20211207224013.880775-1-npache@redhat.com> <20211207224013.880775-2-npache@redhat.com> <20211207154438.c1e49a3f0b5ebc9245aac61b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=shW1fHmB; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2888C12000B X-Stat-Signature: ejinxknhrfu51n5rrs3yfiinbu98baix X-HE-Tag: 1641834985-566237 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 10-01-22 12:09:50, Rafael Aquini wrote: [...] > > 3. From David, fix in node_zonelist(). > > https://lore.kernel.org/all/51c65635-1dae-6ba4-daf9-db9df0ec35d8@redhat.com/T/#u > > It seems to me that (3) is the simplest and effective way to cope with this case Did you have chance to look at http://lkml.kernel.org/r/20211214100732.26335-1-mhocko@kernel.org -- Michal Hocko SUSE Labs