From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3696C433EF for ; Mon, 10 Jan 2022 13:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04D816B0075; Mon, 10 Jan 2022 08:28:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3E266B0078; Mon, 10 Jan 2022 08:28:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2D0A6B007B; Mon, 10 Jan 2022 08:28:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id D3B5C6B0075 for ; Mon, 10 Jan 2022 08:28:58 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 821D6180A0D63 for ; Mon, 10 Jan 2022 13:28:58 +0000 (UTC) X-FDA: 79014457956.17.D72DC15 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id B55A1140010 for ; Mon, 10 Jan 2022 13:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bIvQ3iiBdG90qy5CiZJ/j6Ne9iVxuyc7lz8mhd/rS0c=; b=Wi7e7e53xjQVSyoM7SoAi03iCf 6Zhihcd5Q/URTY8byyLMah09OIcbpqBm7eJJFDDdWHBg4RuS+D6HwG4lXTjY5kMBzbwQEsEaugrUb uZ4LedlfNsol3F/G8GMt86ejqnsCj4Sr+hbKkgBRMNKj+mvC9Xok3xIVhZOZdugu2DweFXmwNAjHS PEJnb8HCVgRrK6ypTBNpjWiQqvOsQ6AkyPpcghQmnY06hwvUmb4kbcGx5P4foI04KjqPKmtoS2sW1 AKIWdVORgUW4eD+lJjmu0K/Y4um9XcbS+4aShcZbvP+0vpr3AA9fSMPOctpmW9Z75rBNXmyNuW4VL 09LuSPQg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6uj8-002SEg-0L; Mon, 10 Jan 2022 13:28:46 +0000 Date: Mon, 10 Jan 2022 13:28:45 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, John Hubbard , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 05/28] gup: Change the calling convention for compound_next() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B55A1140010 X-Stat-Signature: 1pggiwg4dzef5ke1zmiyo7kutjem6oik Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wi7e7e53; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1641821337-963514 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 12:27:29AM -0800, Christoph Hellwig wrote: > On Mon, Jan 10, 2022 at 04:23:43AM +0000, Matthew Wilcox (Oracle) wrote: > > Return the head page instead of storing it to a passed parameter. > > Looks good, but same comment about maybe passing list and npages first. Done for both.