From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411A3C433F5 for ; Mon, 10 Jan 2022 08:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C953E6B00A0; Mon, 10 Jan 2022 03:36:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C458A6B00A2; Mon, 10 Jan 2022 03:36:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34506B00A3; Mon, 10 Jan 2022 03:36:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id A6DE16B00A0 for ; Mon, 10 Jan 2022 03:36:49 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6FDDE944C8 for ; Mon, 10 Jan 2022 08:36:49 +0000 (UTC) X-FDA: 79013721738.13.5134C73 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 2504440007 for ; Mon, 10 Jan 2022 08:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OJSjHN65nlGg+U/iNgU8GoUCcDZpJKnJahxOEMAFNXE=; b=Un+aYWmr1vviPqISIhoZ5dyHzO enQvQowFK36MohI/hg/n/QW4EPHN5uem5QOXlmBBZ4ZWDjYs8CVQkF7qVi9q0V/y51ZDYUDCq3Wm+ 6+1tFF0AQ0+4saWMUWNYUyDs7EIEF3j77YeZu5ffZTlXGevpvulRP/yAocd+B0lV57eI2hIHGgWuE p97Mdvn4hlPhXIyRqL8u6iiiy96q1N0Vp7IBb82XixrcLMzYbcAp6V02ks4LTrWl6EEhkXpb+ztPJ /gLhrUNvrRMnsPJDdxbIyTyjRkUBKU35W7tOkeNqR/K6zGswKggjav8jJec2uJ43qnGq6t3yJwmRi vtHAbYzA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6qAZ-009vUY-Rf; Mon, 10 Jan 2022 08:36:47 +0000 Date: Mon, 10 Jan 2022 00:36:47 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 19/28] gup: Convert try_grab_page() to call try_grab_folio() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-20-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-20-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2504440007 X-Stat-Signature: i9h54fz99s5yyuikrpcneo5hncccwifn Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Un+aYWmr; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1641803808-369878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:57AM +0000, Matthew Wilcox (Oracle) wrote: > try_grab_page() only cares about success or failure, not about the > type returned. Looks good, Reviewed-by: Christoph Hellwig