From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4E8C433FE for ; Mon, 10 Jan 2022 08:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF8F6B009F; Mon, 10 Jan 2022 03:36:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F7C6B00A0; Mon, 10 Jan 2022 03:36:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E907B6B00A2; Mon, 10 Jan 2022 03:36:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id DA2716B009F for ; Mon, 10 Jan 2022 03:36:30 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 87C6A18201288 for ; Mon, 10 Jan 2022 08:36:30 +0000 (UTC) X-FDA: 79013720940.13.4AD4B30 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 3AB6514000A for ; Mon, 10 Jan 2022 08:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eB11XFakVhlCK/dTLKPVKUovWrOV7iJOxzFzNgcRP/w=; b=lVwDyWQ4RoZ5Ny31vBycE1p/Su u3BSTIrWcccO/fnZT30VCjFMGdv4JisDE5B8TgbREx8KmfdMLmZdzkOLH1RfwWjca4eC3RhVQdnO3 6zr4O0wvOQA84rjf5mwPGH5f67pJbqALCmGospoDL4AH97C2ajoubrBreohFpSiPifnML3l2oOmyY cAk2Zpse/O73ll43fUO+lETlSnCAAjBFrgLEbxOeTAkDU1NDfz7lQ+p6NGbPkXzXq4nM4Cpwwpy5m 3f3Rn3ET2DqzsjYF43HzVKx0gA00czoqDxQtvdKE+YIrDGVKWb1A0pEaBd0zttycqzKv85TcBIL0R LdbIlb9w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6qAH-009vHA-4w; Mon, 10 Jan 2022 08:36:29 +0000 Date: Mon, 10 Jan 2022 00:36:29 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 18/28] hugetlb: Use try_grab_folio() instead of try_grab_compound_head() Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-19-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-19-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3AB6514000A X-Stat-Signature: agmhyygiwsz8ctnf15ir638b713zgzhd Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lVwDyWQ4; spf=none (imf23.hostedemail.com: domain of BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+996bc53df2b455107366+6714+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1641803790-475982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 04:23:56AM +0000, Matthew Wilcox (Oracle) wrote: > follow_hugetlb_page() only cares about success or failure, so it doesn't > need to know the type of the returned pointer, only whether it's NULL > or not. Looks good, Reviewed-by: Christoph Hellwig