From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EAFC433F5 for ; Sat, 8 Jan 2022 06:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1159C6B0072; Sat, 8 Jan 2022 01:21:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09E3B6B0073; Sat, 8 Jan 2022 01:21:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECF826B0074; Sat, 8 Jan 2022 01:21:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id DEFA26B0072 for ; Sat, 8 Jan 2022 01:21:47 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9CF6C8FD09 for ; Sat, 8 Jan 2022 06:21:47 +0000 (UTC) X-FDA: 79006123854.03.072F4C4 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf05.hostedemail.com (Postfix) with ESMTP id 2F61E10000A for ; Sat, 8 Jan 2022 06:21:47 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id h1so6669913pls.11 for ; Fri, 07 Jan 2022 22:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nKc3rHw8bLwTpQvgM5tlXB3o1woijjKVi3JGNy/T3oI=; b=cnQgiY2duio95ZANcJ59sGBdyTbzR2ePP/TEDa3Zk6tlbaHGGl5n+TmNviPBnL6U5g /4Zu2d/WScAOJPSSB5kHGkH1kBESJxagJa7QQuxf7RWP6IfjScchzEY+XXM3ntEvMUa4 9ovF+c+Bqgun4tTet9pLYiBqou6XYOX7kZij5dxAvf05IRVgYX0nCp2UMMk41Gmf9U37 5BWeeOnaIDdql04Kg8qv3La1gDozmkURxc1iTKLFZNf2L5LTOcnBt1LEzammYEBxxR7/ UPavqLQZ4d2aaijYLUkhq1VDKvsNGFPX8gJL5F/bZYje+XqDzb0ahA7h1R1MdVHMd2Mh Plmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nKc3rHw8bLwTpQvgM5tlXB3o1woijjKVi3JGNy/T3oI=; b=qtJSH+fJ9R8tVL9H+nd3gstGgMU2A8d0ZcqtIEC5vYjxq0JG2dynQ5152ydXsBG36K T2SBqog0N1Q2Bergcdpy+haClYK4dElwkkJOSf3IQ2FVCFdeQau9FcKLapHDiQPPk84A 26RCS4rvc/oXnsT9vSuNQTqkp3JVldRpWJ4n/qfaVPQuorrMrJy385pEn0cYKo413ORa pEMn96K/f4+49UygsBhqkl5QjWxtFX3UDgTd8sxg8HrI5rIhhlmsWO4PQw0cNL3ro/l3 dJlQ0ckECzY3nsZQeUioe2uHVePnCY0huBqkrOAXb7aJ6+Eu4l+taybkf9FnKc+lNzY5 tv6Q== X-Gm-Message-State: AOAM531XhBFqfuO9zOGp34hgFTOYO/ldpIfVFVFucBXQKgxPoa6gVKld 2qJ50wpLtDbfx5o3/cy4xJMHo0RfSK2GnA== X-Google-Smtp-Source: ABdhPJz0kNd0pZAXiXuhcKhdFtZaMW8SNnMibCudhHmWDslnoTVHw1hZrQDx8flSDYl5v1p8gY/pAg== X-Received: by 2002:a17:90a:4a11:: with SMTP id e17mr14926219pjh.237.1641622906308; Fri, 07 Jan 2022 22:21:46 -0800 (PST) Received: from ip-172-31-30-232.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id c11sm806347pfv.85.2022.01.07.22.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 22:21:46 -0800 (PST) Date: Sat, 8 Jan 2022 06:21:41 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , patches@lists.linux.dev Subject: Re: [PATCH v4 07/32] mm: Convert __ksize() to struct slab Message-ID: References: <20220104001046.12263-1-vbabka@suse.cz> <20220104001046.12263-8-vbabka@suse.cz> <48ab4217-a0c4-19ba-2335-1154086a562d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48ab4217-a0c4-19ba-2335-1154086a562d@suse.cz> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2F61E10000A X-Stat-Signature: ij6z4zapwq6dkogu63zuap8js7gz93oc Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cnQgiY2d; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1641622907-347246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 06, 2022 at 06:26:06PM +0100, Vlastimil Babka wrote: > On 1/6/22 14:42, Hyeonggon Yoo wrote: > > On Tue, Jan 04, 2022 at 01:10:21AM +0100, Vlastimil Babka wrote: > > > > This patch Looks good. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thanks! > :> > > BTW, I see no reason to implement SLAB version of __ksize separately. > > And there are no modules that use __ksize. EXPORT_SYMBOL is unnecessary. > > OK, I'll look at a cleanup later. Or you can try? I want to try it. > > > BTW, Until when can I review your patches? until next week before starting > > window? > > I will send it tomorrow already, so records of any further review will be > archived in the mailing list only, but not git. Thanks again! > Got it. Thanks! > > Thanks! > > > >> -- > >> 2.34.1 > >> >