From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3771C433F5 for ; Thu, 6 Jan 2022 13:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E5626B007B; Thu, 6 Jan 2022 08:42:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16C8D6B0081; Thu, 6 Jan 2022 08:42:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F28336B0082; Thu, 6 Jan 2022 08:42:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id DE4006B007B for ; Thu, 6 Jan 2022 08:42:23 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F1B00181E4905 for ; Thu, 6 Jan 2022 13:42:22 +0000 (UTC) X-FDA: 78999976524.11.E26A054 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf31.hostedemail.com (Postfix) with ESMTP id 0729C2000D for ; Thu, 6 Jan 2022 13:41:55 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id v13so2579509pfi.3 for ; Thu, 06 Jan 2022 05:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WIn9iUdeD2B4Cs6ET+8eDagQcKrMAeD/AEHYHYVJ70M=; b=cFvDgcrgvYMhqDAP6aWV8xTfVgdXVkZBqgCxGQJ7mrgJ8ZIyUJeiNN+E8olDsiCQg1 aap/fCopxF2Ah17Dxq3cFjeuCHiE6GF8IMlwt930OB1lLP11i924vP0Eb/fv/ttatNkk tTW7kG3HZUx/zV+9AatW5WHTVgVB2748Jr3w3j00WljsHGCee41V+xOnrw1nTTWRN+CZ nZ1mq3q8t1veoAftWBB0+zBX4b0zGVJHVEhCdNxLKjZKJNzw6L0SxbihmxD/eeKUMs5A zXWhK6GT6xbJMJ/1GJeeT3NVDcUybvzTlzB9JKzDW298Ga5WeiCGtNqH2po6r0i+/ZDm EewQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WIn9iUdeD2B4Cs6ET+8eDagQcKrMAeD/AEHYHYVJ70M=; b=Gcz+ExTYrojUZFjhmx+5EohAj8/hzSEhLBVpOXzzRYIS9aYrhzqYmBFgZi3usAgRY3 lMQoqadJXj6Zb0kPZDLEzqlwkzQhRc2NEOHp4N9nD4uc+lFassx7G4xXy3Gn3BXiYIQr qzicjm40cNcx+7dAt6Z63NNSI+6NgNxjweh1Gd2u8kWXs6hO54ZIhCVOROBZ/BgwO5Xp t/ru9nqjtLgFkWfUgWwlMnsHvYh9LsyeeH/2rg4K/qDWIH8AG7+/08Nlwtke3jptNQ5L aDKOHUKka6P6HOWOo+4WxkDgKTlNvbk34FbiQcx+PQwZer43YRBf178uioNU/u2HwCgR k6Hw== X-Gm-Message-State: AOAM530t5+zfChPfzogC9TcUZtyhnDUsV1H+I5GktqAPtXsJFVPQnAY4 9rChI5EEU89Jwx3UUpY9aw0= X-Google-Smtp-Source: ABdhPJzUtaqkp6M0FNqOSaOMNma7sCaWHhoGrK773bb5+SPhe16yFSgp3G2sN3fDSyCsB1Mj7PpuiA== X-Received: by 2002:a05:6a00:8c5:b0:4bc:4c7e:7742 with SMTP id s5-20020a056a0008c500b004bc4c7e7742mr34388586pfu.18.1641476541692; Thu, 06 Jan 2022 05:42:21 -0800 (PST) Received: from ip-172-31-30-232.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id nn16sm6696227pjb.54.2022.01.06.05.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 05:42:21 -0800 (PST) Date: Thu, 6 Jan 2022 13:42:16 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , patches@lists.linux.dev Subject: Re: [PATCH v4 07/32] mm: Convert __ksize() to struct slab Message-ID: References: <20220104001046.12263-1-vbabka@suse.cz> <20220104001046.12263-8-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220104001046.12263-8-vbabka@suse.cz> Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cFvDgcrg; spf=pass (imf31.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0729C2000D X-Stat-Signature: xgq43szxpkzwjdpwrqqpptufkrdchtuu X-HE-Tag: 1641476515-658642 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 04, 2022 at 01:10:21AM +0100, Vlastimil Babka wrote: > From: "Matthew Wilcox (Oracle)" > > In SLUB, use folios, and struct slab to access slab_cache field. > In SLOB, use folios to properly resolve pointers beyond > PAGE_SIZE offset of the object. > > [ vbabka@suse.cz: use folios, and only convert folio_test_slab() == true > folios to struct slab ] > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Vlastimil Babka > Acked-by: Johannes Weiner > Reviewed-by: Roman Gushchin > --- > mm/slob.c | 8 ++++---- > mm/slub.c | 12 +++++------- > 2 files changed, 9 insertions(+), 11 deletions(-) > > diff --git a/mm/slob.c b/mm/slob.c > index 03deee1e6a94..c8a4290012a6 100644 > --- a/mm/slob.c > +++ b/mm/slob.c > @@ -570,7 +570,7 @@ EXPORT_SYMBOL(kfree); > /* can't use ksize for kmem_cache_alloc memory, only kmalloc */ > size_t __ksize(const void *block) > { > - struct page *sp; > + struct folio *folio; > int align; > unsigned int *m; > > @@ -578,9 +578,9 @@ size_t __ksize(const void *block) > if (unlikely(block == ZERO_SIZE_PTR)) > return 0; > > - sp = virt_to_page(block); > - if (unlikely(!PageSlab(sp))) > - return page_size(sp); > + folio = virt_to_folio(block); > + if (unlikely(!folio_test_slab(folio))) > + return folio_size(folio); > > align = max_t(size_t, ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN); > m = (unsigned int *)(block - align); > diff --git a/mm/slub.c b/mm/slub.c > index c94fb4b4d655..269e10d341a8 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4527,19 +4527,17 @@ void __check_heap_object(const void *ptr, unsigned long n, struct page *page, > > size_t __ksize(const void *object) > { > - struct page *page; > + struct folio *folio; > > if (unlikely(object == ZERO_SIZE_PTR)) > return 0; > > - page = virt_to_head_page(object); > + folio = virt_to_folio(object); > > - if (unlikely(!PageSlab(page))) { > - WARN_ON(!PageCompound(page)); > - return page_size(page); > - } > + if (unlikely(!folio_test_slab(folio))) > + return folio_size(folio); > > - return slab_ksize(page->slab_cache); > + return slab_ksize(folio_slab(folio)->slab_cache); > } > EXPORT_SYMBOL(__ksize); > This patch Looks good. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> BTW, I see no reason to implement SLAB version of __ksize separately. And there are no modules that use __ksize. EXPORT_SYMBOL is unnecessary. BTW, Until when can I review your patches? until next week before starting window? Thanks! > -- > 2.34.1 >