From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A161C433EF for ; Thu, 6 Jan 2022 06:44:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC0A06B0072; Thu, 6 Jan 2022 01:44:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48BD6B0073; Thu, 6 Jan 2022 01:44:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9526B0074; Thu, 6 Jan 2022 01:44:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 7BB416B0072 for ; Thu, 6 Jan 2022 01:44:34 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 324EC9634C for ; Thu, 6 Jan 2022 06:44:34 +0000 (UTC) X-FDA: 78998923668.07.3BEFA32 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 0B665180009 for ; Thu, 6 Jan 2022 06:44:31 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id v13so1746150pfi.3 for ; Wed, 05 Jan 2022 22:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+XhwRad15ARCCz7PlhBFDwqIW/JNQ6pxL2qxvbxceos=; b=OCAnvGF/gg4vCqpsgCqY8xzROD0pzmq64psau5Eaw/qtFZ4gBmNXYscubAkD32ymez NmL5PbZuHjHwZHCNaYy1xK2dNQrs2fSNK4NynBkyLj/Gb/PwilMt50QLRPnFgaozAIlY Tc2sbYG+B+izb1YJrvMjeSqsHFjrJMWCvBaFY1jig5dVPBFoIrPzy5JnYCq/Aau24s9d T3cI97EB9Arq6cPBgmIpg/kTuxFSffN95SJt7gCepBnaSa+P+dFUFjLvAXLfbH9QOAKx R+n4TYgyigVk8fBcoDXI8xejyh+odqtCu3eIuZ9hmrLQ4nNc3/gtmLcKBgXyBO7amE4i bppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+XhwRad15ARCCz7PlhBFDwqIW/JNQ6pxL2qxvbxceos=; b=LYX1ZpLkVLS0VvKLk/CqExftvuWwzUZWlvBCf3J+PIp6aw7BDfPPmPNtizNUXlAkTt yO5GwEJ6NLwCCwd1oXuw9JF586d5y7fjZYoK6qZhUOyk8tZ55easEf7tNOV+aHLxUKzY KRY2QNZs97SyyCRMVho3VaXfJxf8pN/JYtAxuYfzyUJJo34A4EEsH/ELvALiI0ocfCve OvaRNLcyPkrPUT38l91uu48WCr8M1osJW+hLDR2WXIrdseE2JJl3hUqA8ZCjfYJ1JIQG 3pQ+h+t3KoMAkJ1XmShULAkxSmP3Jqvb4XJFtFF38yMAirTZ4Mu47pIFYcMpaRFq2bTa g96g== X-Gm-Message-State: AOAM531mMYqZmiDyZ9FMeFr7kh9+RGuWGoLdyeKEWrzu94Xq8+2RznsC RXoCcZpXP+ugUemiAiRCrb0= X-Google-Smtp-Source: ABdhPJz5su97NryxCuZJ5mNr86k4sQKY3Q+ejq8ibz5/9Wv/pBMH27fiQlGTNwfy7/jtc+rdrDwTmA== X-Received: by 2002:a63:784d:: with SMTP id t74mr36118499pgc.261.1641451472848; Wed, 05 Jan 2022 22:44:32 -0800 (PST) Received: from ip-172-31-30-232.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id mh3sm4967524pjb.26.2022.01.05.22.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 22:44:32 -0800 (PST) Date: Thu, 6 Jan 2022 06:44:28 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Roman Gushchin , patches@lists.linux.dev Subject: Re: [PATCH v4 06/32] mm: Convert virt_to_cache() to use struct slab Message-ID: References: <20220104001046.12263-1-vbabka@suse.cz> <20220104001046.12263-7-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220104001046.12263-7-vbabka@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0B665180009 X-Stat-Signature: 4h9doifnwyitfn3wo75d1s1ohe91biye Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="OCAnvGF/"; spf=pass (imf06.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1641451471-685811 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 04, 2022 at 01:10:20AM +0100, Vlastimil Babka wrote: > From: "Matthew Wilcox (Oracle)" > > This function is entirely self-contained, so can be converted from page > to slab. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Vlastimil Babka > Acked-by: Johannes Weiner > Reviewed-by: Roman Gushchin > --- > mm/slab.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/slab.h b/mm/slab.h > index dd3f72fddff6..1408ada9ff72 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -574,13 +574,13 @@ static inline void memcg_slab_free_hook(struct kmem_cache *s, > > static inline struct kmem_cache *virt_to_cache(const void *obj) > { > - struct page *page; > + struct slab *slab; > > - page = virt_to_head_page(obj); > - if (WARN_ONCE(!PageSlab(page), "%s: Object is not a Slab page!\n", > + slab = virt_to_slab(obj); > + if (WARN_ONCE(!slab, "%s: Object is not a Slab page!\n", > __func__)) > return NULL; > - return page->slab_cache; > + return slab->slab_cache; > } > Looks good, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > static __always_inline void account_slab(struct slab *slab, int order, > -- > 2.34.1 >