From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98AFC433EF for ; Wed, 5 Jan 2022 21:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35B356B0072; Wed, 5 Jan 2022 16:12:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E35F6B0073; Wed, 5 Jan 2022 16:12:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136C46B0078; Wed, 5 Jan 2022 16:12:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id F29156B0072 for ; Wed, 5 Jan 2022 16:12:38 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8AB0695AF4 for ; Wed, 5 Jan 2022 21:12:38 +0000 (UTC) X-FDA: 78997482396.20.BED6AE5 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 36D4514000A for ; Wed, 5 Jan 2022 21:12:38 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id v18so512969ilm.11 for ; Wed, 05 Jan 2022 13:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=ZaehH+x5c0zMI/IfYQs/P2s8KjVJpoFcoUPnh+aQ843si2v3nD3DC7aBVH2zE+H7IV XtKaomiGdT9vzvdrdiYMNczQ4NKF5buM1kOQS4NV1m8sbZ7/KvWCfG6wlcavCzgDRu3z IcI7k4fHp3NQ8f1SrS8r5KhG3fearM36RhnFmjv5QN+q4bMI8CpX03N+yOPa4NpnXfdV u7ez66TZ5917ahjPpH/7swu5B4GjVkgttA13c7TRCjugt20r8n4f0zTa9bIJ1pCFcC69 PhdYDdzGv14ETQauuHZaLzl4lRqnrBcSApmHgmYtJAwIvVNNup/UqMg0qa8XdhM6Q1XM f0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+IvGtL/Cdr/WsdAI8BblKEPdwrJXksPcRkkKFt5itRQ=; b=RqlLo7k2KESq02ESzLmL9hbSlqs+dXzNxroLBA0qxt+yNlj1EIZ25wEM8KTUJAFDNA bAFSmyVvZoNPPNhwYnorRkN0PIXkRmjZ+R7nayxjO0gzZ3GpI86ilWSB6te+oqdAbD8J 8sYq4mDMhtP9zPJhuCJXOdO5VsXnC+a0CJ3oaT5SAZf+9sgUpcAG9l2MWKv4/mZEeOzd ZT+uR47I6azKpmicc7hC04Cq6h82bDz6FY2omLEnghsgQ8134FirIn0oMcarnOgp1bn6 +gZLmc35ipzE7Gg5L8iSKmi74mN6DRGY+QETZV0SzO2KJKblci1zx+W3iovLyYK05Qmd +lJA== X-Gm-Message-State: AOAM531+YFUj6J1Kjf6TE4GAHDjG9nK9qaDad1HVNhFv6gCJEq6Ttyj5 z4uRhys/sfTCjr5VnxAfKE1GfA== X-Google-Smtp-Source: ABdhPJw1baUlWmMI6qXqkj6NLFvmqM5nQ0X8KL8YRZ2jVPVCm0ebJk8cq3iWAIKjjYEoHOCd/Ir/iA== X-Received: by 2002:a05:6e02:148c:: with SMTP id n12mr27203549ilk.51.1641417157408; Wed, 05 Jan 2022 13:12:37 -0800 (PST) Received: from google.com ([2620:15c:183:200:5b02:855e:267d:5b0]) by smtp.gmail.com with ESMTPSA id z16sm907465ilz.60.2022.01.05.13.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 13:12:36 -0800 (PST) Date: Wed, 5 Jan 2022 14:12:33 -0700 From: Yu Zhao To: Linus Torvalds Cc: Andrew Morton , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux-MM , page-reclaim@google.com, the arch/x86 maintainers Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZaehH+x5; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 36D4514000A X-Stat-Signature: 4y75wbqsfjt46fabufh1ctzy3tdix6d5 X-HE-Tag: 1641417158-930715 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 04, 2022 at 01:43:13PM -0800, Linus Torvalds wrote: > On Tue, Jan 4, 2022 at 12:30 PM Yu Zhao wrote: > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > I'll leave this to Andrew. I had some stylistic nits, but all the > actual complexity is in that aging and eviction, and while I looked at > the patches, I certainly couldn't make much of a judgement on them. > > The proof is in the numbers, and they look fine, but who knows what > happens when others test it. I don't see anything that looks worrisome > per se, I just see the silly small things that made me go "Eww". I appreciate your time, I'll address all your comments togather with others' in the next spin, after I hear from Andrew. (I'm assuming he will have comments too.)