From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AC1C433F5 for ; Wed, 5 Jan 2022 05:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660F36B0071; Wed, 5 Jan 2022 00:04:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FF96B0073; Wed, 5 Jan 2022 00:04:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE586B0074; Wed, 5 Jan 2022 00:04:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 414716B0071 for ; Wed, 5 Jan 2022 00:04:40 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DCB36181AF5E6 for ; Wed, 5 Jan 2022 05:04:39 +0000 (UTC) X-FDA: 78995043078.04.1EBD982 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf31.hostedemail.com (Postfix) with ESMTP id 1F75120008 for ; Wed, 5 Jan 2022 05:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qdvFtEDVM0dPxsHIUgsOeL1S6B59tFrhmjghuK1Fv1U=; b=TP7Y0szTx9/DOCOF6PTAKfpUbP 9khzlh+IIwmlsNC9uPp3MKrnnKEva5f5v9IaZGbd/0OMa1h7scLJNyGPtiz5st8nlOi7d+z6RFqbZ BVOOlPf1lmTaF+64KgJ2kI1PQCmKdMnWgpxxjpZL4gU79ZGOLpJncKjQl2PgzQ6cEQiqSudgUpGva dCqxxVjw0WUCCaKyyE0o4XphmGnYdE/tOoiu34umAvoLyXMGECctlTVEON9+kop8Nq1fiLlb8qnOX rjQks28RyVV6/8b6vS/gohcUJLTUovrB1Qa43MiZpgiN5AuVxCpVSGXjlikuIjEuVpBW+nckG7ckf 8bOuJwuA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4yTU-00EHKS-R4; Wed, 05 Jan 2022 05:04:36 +0000 Date: Wed, 5 Jan 2022 05:04:36 +0000 From: Matthew Wilcox To: John Hubbard Cc: linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 02/17] mm: Add folio_pincount_available() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-3-willy@infradead.org> <20a06269-3bea-27c3-568f-6459fa3374ab@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20a06269-3bea-27c3-568f-6459fa3374ab@nvidia.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1F75120008 X-Stat-Signature: 7hr9trn1fuyc6b95mn1k3owznkt4r6zy Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TP7Y0szT; spf=none (imf31.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1641359053-13265 X-Bogosity: Ham, tests=bogofilter, spamicity=0.007792, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 04, 2022 at 01:40:36PM -0800, John Hubbard wrote: > > - page = compound_head(page); > > - return PageCompound(page) && compound_order(page) > 1; > > + return folio_order(folio) > 1; > > I see, no need to look at the compound page head, because folio_order() returns > zero for tail pages, and neatly avoids all of that. Did you mean base pages instead of tail pages? A folio can never be a tail page.