From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2774C433F5 for ; Tue, 4 Jan 2022 08:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DBDE6B007D; Tue, 4 Jan 2022 03:32:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38B286B007E; Tue, 4 Jan 2022 03:32:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A0EC6B0080; Tue, 4 Jan 2022 03:32:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 1EBA76B007D for ; Tue, 4 Jan 2022 03:32:58 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D3309181AF5F4 for ; Tue, 4 Jan 2022 08:32:57 +0000 (UTC) X-FDA: 78991939194.15.A0AF3DD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP id 7F4AA2000A for ; Tue, 4 Jan 2022 08:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+G6UsLEDJmM9zfWgBx0dhTp0WSHPdJI4mUjQDTqCXgg=; b=rGzonp/s5BGnExMChIr2bipFXj weqCk4I4vF/pH+uxjbqNmlO6CwhGp3O8rIPUNoTYHTIUOIMtiI/V4NkeQO5gVzjP9LNVWVpBVaz85 ArxcH2W9TKt99FfAS+EHWgA8gmhpBIe00FeCGufkIMDwITnQ2qXnyIm6WzYTVkpQsUrxipqikGilT N4/zrhlN3Y/DMXLopCNEOHmqCxW+5JK4CY0n+2qs6j3ZEWE9CwMgjIILxV+EEDu8vIb1/X9SfSYLq wX3mcvPQyvnNzzpF56kUOrlG5/0z7dxXkHdZAQw9LbrJoRzlkZgmLU+bdYkkNeQx/k2i0KRQeoOMC yrd8pHhw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fFX-00AjvZ-To; Tue, 04 Jan 2022 08:32:55 +0000 Date: Tue, 4 Jan 2022 00:32:55 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 14/17] gup: Convert for_each_compound_head() to gup_for_each_folio() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-15-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 7F4AA2000A X-Stat-Signature: kyecn9co9463pwd4cuayh4tjw348xn13 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="rGzonp/s"; spf=none (imf31.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-HE-Tag: 1641285152-879756 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:26PM +0000, Matthew Wilcox (Oracle) wrote: > This macro can be considerably simplified by returning the folio from > gup_folio_next() instead of void from compound_next(). Convert both > callers to work on folios instead of pages. This looks sensible, but looking at the macro I wonder if an open coded while loop (using your new calling conventions) wouldn't make formore readable code than the macro: int i = 0; ... while ((folio = gup_folio_next(i, npages, list, &ntail) != NULL)) { ... i += ntails; }