From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B3CC433EF for ; Tue, 4 Jan 2022 08:35:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F6B6B007D; Tue, 4 Jan 2022 03:35:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50F386B007E; Tue, 4 Jan 2022 03:35:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FDB36B0080; Tue, 4 Jan 2022 03:35:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 2DE316B007D for ; Tue, 4 Jan 2022 03:35:41 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E214490F78 for ; Tue, 4 Jan 2022 08:35:40 +0000 (UTC) X-FDA: 78991946040.03.5B9AAA5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 56AB1C000D for ; Tue, 4 Jan 2022 08:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0lusgSX9BNtj7mqpr6rNWBoMmP9tAHXxMD/Zkj5F8Ec=; b=xc+9s3IkGSo0Z27lgi61vmFp9z 3fxFPHKRnKsyM2HfdIouAL2m9mLFttYxB/KkUvsbfv3rKyPz6gK5hOERmJSYzIBH9xryDcsstgGC+ EnOaLVr9G4y0Wa/gmrGKO/a9bNlAPQD9tdPRVhgNPkbyv1+R9nYLGud5TdbtMJo5IJNJPhjTDulT1 xQCv9WShvVvMYwtHcnmbT9eT8tlNQcepDLCcOIBuD5Tl3drxKfd8d9GX/KFaeSkHSm58Sx3qt+tbH lAI64mZ8dGDksTuYWXIcJC4LKcdLOT7G2Fvu/ckIlgq7SoaFfnCIYwsQXtTDu6eiOgVYyidPcV45W ttQzs9mA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fIB-00AkVl-B6; Tue, 04 Jan 2022 08:35:39 +0000 Date: Tue, 4 Jan 2022 00:35:39 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 15/17] gup: Convert for_each_compound_range() to gup_for_each_folio_range() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-16-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 56AB1C000D X-Stat-Signature: 4r59hi3fiy31ytrusywjqp6o8emn7anz Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xc+9s3Ik; spf=none (imf22.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1641285339-81428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:27PM +0000, Matthew Wilcox (Oracle) wrote: > This macro can be considerably simplified by returning the folio from > gup_folio_range_next() instead of void from compound_next(). Convert the > only caller to work on folios instead of pages. > > This removes the last caller of put_compound_head(), so delete it. Looks good, but same comment about dropping the macro.