From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF28BC433F5 for ; Tue, 4 Jan 2022 08:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DCF86B007E; Tue, 4 Jan 2022 03:26:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 763856B0080; Tue, 4 Jan 2022 03:26:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62B7B6B0081; Tue, 4 Jan 2022 03:26:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 547A46B007E for ; Tue, 4 Jan 2022 03:26:52 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0503C18195413 for ; Tue, 4 Jan 2022 08:26:52 +0000 (UTC) X-FDA: 78991923864.02.DF12D75 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 15C78180002 for ; Tue, 4 Jan 2022 08:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bg/rwGW5Xze6/YsbwtrNoHN9w2xqJTUSyTtf8KmohkY=; b=XBgE+6h2rAf16Izo2FLrV/2o59 FptrQYNpIsPr5ZmaY8gZKzYQZPrXPRH/Hr+6BRRsgjfqKjUwEKuGvhPRCXf38/fMazxEPBwiEu5oX Ya1zdS23qB1ueB6ubVKqLERHqX8dwviLurlnkPdLVb34L4Bwk7ekHU6EdtIVk3d3s3+jc/Xz4/GeP NvJYB3Ook39PnMQHylxLeMC0YHDUZ0jwGrkEuzsUeOEY6XYQQ07MveYuyXw/6JGaaOvyoftcNU1EY f6fOjBvY/N5RPcOh3oJwOqic92fJ41T76kueuyVNOtT+b2I414SvBWg0NoIESZzVlWBPhIYSeg5PV mr5QuA3A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4f9e-00AjKf-Nz; Tue, 04 Jan 2022 08:26:50 +0000 Date: Tue, 4 Jan 2022 00:26:50 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 11/17] gup: Convert gup_huge_pmd() to use a folio Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-12-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XBgE+6h2; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 15C78180002 X-Stat-Signature: ashe6ib6zunat7m4ii54zu9uksjyjs6o X-HE-Tag: 1641284809-656161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:23PM +0000, Matthew Wilcox (Oracle) wrote: > Use the new folio-based APIs. Also fix an assumption that memmap is > contiguous. The changes looks good, but I'd really split all these nth_page conversions into a single prep patch.