From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF03EC433EF for ; Tue, 4 Jan 2022 08:26:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67B3B6B007D; Tue, 4 Jan 2022 03:26:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 603FC6B0080; Tue, 4 Jan 2022 03:26:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F3646B0081; Tue, 4 Jan 2022 03:26:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 418E36B007D for ; Tue, 4 Jan 2022 03:26:25 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E82998B305 for ; Tue, 4 Jan 2022 08:26:24 +0000 (UTC) X-FDA: 78991922688.06.D0847DB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 9B1C340002 for ; Tue, 4 Jan 2022 08:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2eaBEOSYlkoJmOlMyTDx/p6SHIN+kTnRmdRpCSUD4LY=; b=HfVbwOB4hJ6vwqWXQOrZyfmoMs NPs8Ia07r1j9xCgj4kgE/Cr38RuHwWFpggRcsv9n+PcYmnXdL72PiGfqBmU+i4G+CCFXLFLMPpxci 9RnLiTTpWI/rLv9g3WqDt8k4kf8IZ+w/euj0gN07HRhTV0C7XIsMMClnhv0HfIdASlFU/2iNPRBEL NxUrdDPRJcJZhB9fofYYJK8kWLy/tR9nDaK3VyURbdoxyLaAAPk//vTolZAgDVwzu9mj7JBHWxTK8 EWJ2RRF/wdBPMapu/TLLRQLGUB9Xo/lDLW0OUW3uAUmWkPS8T5wNUNc5LOIqkOvLMSLPnxP9BsSOW 3GYD/FHg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4f9D-00AjH5-IW; Tue, 04 Jan 2022 08:26:23 +0000 Date: Tue, 4 Jan 2022 00:26:23 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 10/17] gup: Convert gup_hugepte() to use a folio Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 9B1C340002 X-Stat-Signature: awmuw5xbu5zrsuj7djjuqwu68m3ufa7r Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HfVbwOB4; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1641284784-691679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:22PM +0000, Matthew Wilcox (Oracle) wrote: > There should be little to no effect from this patch; just removing > uses of some old APIs. > > While I'm looking at this, take the opportunity to use nth_page() > instead of doing the arithmetic ourselves in case hugetlbfs pages > are ever allocated across memmap boundaries. I'd split this into two patches, but otherwise this looks good: Reviewed-by: Christoph Hellwig