From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org, John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 10/17] gup: Convert gup_hugepte() to use a folio
Date: Tue, 4 Jan 2022 00:26:23 -0800 [thread overview]
Message-ID: <YdQEr8CTLNFHPfRZ@infradead.org> (raw)
In-Reply-To: <20220102215729.2943705-11-willy@infradead.org>
On Sun, Jan 02, 2022 at 09:57:22PM +0000, Matthew Wilcox (Oracle) wrote:
> There should be little to no effect from this patch; just removing
> uses of some old APIs.
>
> While I'm looking at this, take the opportunity to use nth_page()
> instead of doing the arithmetic ourselves in case hugetlbfs pages
> are ever allocated across memmap boundaries.
I'd split this into two patches, but otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-01-04 8:26 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 21:57 [PATCH 00/17] Convert GUP to folios Matthew Wilcox (Oracle)
2022-01-02 21:57 ` [PATCH 01/17] mm: Add folio_put_refs() Matthew Wilcox (Oracle)
2022-01-04 8:00 ` Christoph Hellwig
2022-01-04 21:15 ` John Hubbard
2022-01-02 21:57 ` [PATCH 02/17] mm: Add folio_pincount_available() Matthew Wilcox (Oracle)
2022-01-04 8:01 ` Christoph Hellwig
2022-01-04 18:25 ` Matthew Wilcox
2022-01-04 21:40 ` John Hubbard
2022-01-05 5:04 ` Matthew Wilcox
2022-01-05 6:24 ` John Hubbard
2022-01-02 21:57 ` [PATCH 03/17] mm: Add folio_pincount_ptr() Matthew Wilcox (Oracle)
2022-01-04 8:02 ` Christoph Hellwig
2022-01-04 21:43 ` John Hubbard
2022-01-06 21:57 ` William Kucharski
2022-01-02 21:57 ` [PATCH 04/17] mm: Convert page_maybe_dma_pinned() to use a folio Matthew Wilcox (Oracle)
2022-01-04 8:03 ` Christoph Hellwig
2022-01-04 22:01 ` John Hubbard
2022-01-02 21:57 ` [PATCH 05/17] gup: Add try_get_folio() Matthew Wilcox (Oracle)
2022-01-04 8:18 ` Christoph Hellwig
2022-01-05 1:25 ` John Hubbard
2022-01-05 7:00 ` John Hubbard
2022-01-07 18:23 ` Jason Gunthorpe
2022-01-08 1:37 ` Matthew Wilcox
2022-01-08 2:36 ` John Hubbard
2022-01-10 15:01 ` Jason Gunthorpe
2022-01-02 21:57 ` [PATCH 06/17] mm: Remove page_cache_add_speculative() and page_cache_get_speculative() Matthew Wilcox (Oracle)
2022-01-04 8:18 ` Christoph Hellwig
2022-01-05 1:29 ` John Hubbard
2022-01-02 21:57 ` [PATCH 07/17] gup: Add gup_put_folio() Matthew Wilcox (Oracle)
2022-01-04 8:22 ` Christoph Hellwig
2022-01-05 6:52 ` John Hubbard
2022-01-06 22:05 ` William Kucharski
2022-01-02 21:57 ` [PATCH 08/17] gup: Add try_grab_folio() Matthew Wilcox (Oracle)
2022-01-04 8:24 ` Christoph Hellwig
2022-01-05 7:06 ` John Hubbard
2022-01-02 21:57 ` [PATCH 09/17] gup: Convert gup_pte_range() to use a folio Matthew Wilcox (Oracle)
2022-01-04 8:25 ` Christoph Hellwig
2022-01-05 7:36 ` John Hubbard
2022-01-05 7:52 ` Matthew Wilcox
2022-01-05 7:57 ` John Hubbard
2022-01-02 21:57 ` [PATCH 10/17] gup: Convert gup_hugepte() " Matthew Wilcox (Oracle)
2022-01-04 8:26 ` Christoph Hellwig [this message]
2022-01-05 7:46 ` John Hubbard
2022-01-02 21:57 ` [PATCH 11/17] gup: Convert gup_huge_pmd() " Matthew Wilcox (Oracle)
2022-01-04 8:26 ` Christoph Hellwig
2022-01-05 7:50 ` John Hubbard
2022-01-02 21:57 ` [PATCH 12/17] gup: Convert gup_huge_pud() " Matthew Wilcox (Oracle)
2022-01-05 7:58 ` John Hubbard
2022-01-02 21:57 ` [PATCH 13/17] gup: Convert gup_huge_pgd() " Matthew Wilcox (Oracle)
2022-01-05 7:58 ` John Hubbard
2022-01-02 21:57 ` [PATCH 14/17] gup: Convert for_each_compound_head() to gup_for_each_folio() Matthew Wilcox (Oracle)
2022-01-04 8:32 ` Christoph Hellwig
2022-01-05 8:17 ` John Hubbard
2022-01-09 4:39 ` Matthew Wilcox
2022-01-09 8:01 ` John Hubbard
2022-01-10 15:22 ` Jan Kara
2022-01-10 15:52 ` Matthew Wilcox
2022-01-10 20:36 ` Jan Kara
2022-01-10 21:10 ` Matthew Wilcox
2022-01-17 12:07 ` Jan Kara
2022-01-02 21:57 ` [PATCH 15/17] gup: Convert for_each_compound_range() to gup_for_each_folio_range() Matthew Wilcox (Oracle)
2022-01-04 8:35 ` Christoph Hellwig
2022-01-05 8:30 ` John Hubbard
2022-01-02 21:57 ` [PATCH 16/17] mm: Add isolate_lru_folio() Matthew Wilcox (Oracle)
2022-01-04 8:36 ` Christoph Hellwig
2022-01-05 8:44 ` John Hubbard
2022-01-06 0:34 ` Matthew Wilcox
2022-01-02 21:57 ` [PATCH 17/17] gup: Convert check_and_migrate_movable_pages() to use a folio Matthew Wilcox (Oracle)
2022-01-04 8:37 ` Christoph Hellwig
2022-01-05 9:00 ` John Hubbard
2022-01-06 22:12 ` [PATCH 00/17] Convert GUP to folios William Kucharski
2022-01-07 18:54 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdQEr8CTLNFHPfRZ@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox