From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EABC433F5 for ; Tue, 4 Jan 2022 08:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E216A6B007D; Tue, 4 Jan 2022 03:25:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE2D6B007E; Tue, 4 Jan 2022 03:25:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0A766B0080; Tue, 4 Jan 2022 03:25:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id C54256B007D for ; Tue, 4 Jan 2022 03:25:00 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7F74D181616CE for ; Tue, 4 Jan 2022 08:25:00 +0000 (UTC) X-FDA: 78991919160.12.C6AC494 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 8AC3A40008 for ; Tue, 4 Jan 2022 08:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k5uCoB3W5Yq8258l1yGwSMo0E8tvoDSjqFNLmNDYawA=; b=arq6SU1+eqNimaJZgbVtnZOyJS JRgEd0VrIIs74fyw7vmqzh7QiWvnk5fm285/omRZe8T7qCLbcw3kcibYT1afjNKoPAkykFEYIBMO7 XsXa7xYm3jEGeGo501nINva5x4OeHnekdRoVh+/uRPTJ7sD+lqYrVmZmMqfaHCHB2I5rmDz6omE3h EcaXYee5ENHxWzELZylrFKjDKrPUt7KCueX2OyiqzBtlta4NJR2Ng+xZs7pt4sbdN9AZPBcXucd/p twwVSiNbH18shf1iXWaB1yhPJhN05yZnv2TbWg0iF/bsfy5d95WXN3ZRdnY7ptuzdYbY/aHLuh45E Fz7OuPZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4f7q-00AjAI-QI; Tue, 04 Jan 2022 08:24:58 +0000 Date: Tue, 4 Jan 2022 00:24:58 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 08/17] gup: Add try_grab_folio() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8AC3A40008 X-Stat-Signature: 54635z8i5k7i1mzyp7cx6if1gkbdn548 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=arq6SU1+; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1641284679-763714 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:20PM +0000, Matthew Wilcox (Oracle) wrote: > /** > - * try_grab_compound_head() - attempt to elevate a page's refcount, by a > + * try_grab_folio() - attempt to elevate a page's refcount, by a s/page/folio/ ? > - * > * @page: pointer to page to be grabbed and here something about page inside a folio? Otherwise this looks fine, but I wonder if it would make more sense to already introduce try_grab_folio earlier when you convert try_grab_compound_head to use folios internally.