From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D060CC433F5 for ; Tue, 4 Jan 2022 08:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 597116B007D; Tue, 4 Jan 2022 03:22:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5461E6B007E; Tue, 4 Jan 2022 03:22:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43DC86B0080; Tue, 4 Jan 2022 03:22:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 33DC46B007D for ; Tue, 4 Jan 2022 03:22:07 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E38B3181BF881 for ; Tue, 4 Jan 2022 08:22:06 +0000 (UTC) X-FDA: 78991911852.31.3A940F6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 86660160007 for ; Tue, 4 Jan 2022 08:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NLp/Jrz0IfGHSAS8CS8RiuLN7SAvbip0EYRsYh2M+F0=; b=bFtnj0dAxgW3It1t2snCN7yckj Cb+uGeSUmkBK6dq02GHsSyhzv2s7kzS3pasaGM/uRpXaq+g1CuPi3sM1Cfqjm8/jf7G2WxZPk0x4Q B4nv2CHzBrWkxB8spbWrkjwQ+16/Sf1WxK7iRwUnwD6a5zFAV3VNm60GtLxnOcvtguVAVhZQSSOa0 3nUhWD86EWiV/SDWYrAd29UKi1ghbYjlp3RV63FZ2yzQ/M22Djreh1INJJexWtAKqugXlHk3ee9zw xW99oMoGp4l86Iy7tpFBio70aW8gv+1fXvc5w2Z7/g8M2X2Dk2jQ8+ddCn5qk1Btyyk04rLVrE03S hrgr1a/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4f53-00Aiu9-GE; Tue, 04 Jan 2022 08:22:05 +0000 Date: Tue, 4 Jan 2022 00:22:05 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 07/17] gup: Add gup_put_folio() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 86660160007 X-Stat-Signature: tpitpwtk68u8emnrsaby46fhieghhkti Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bFtnj0dA; dmarc=none; spf=none (imf08.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1641284513-64961 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:19PM +0000, Matthew Wilcox (Oracle) wrote: > put_compound_head() is turned into a call to gup_put_folio(). > This removes the last call to put_page_refs(), so delete it. Except for one more of those nasty page to folio casts (which I assume will go away soon), this looks good: Reviewed-by: Christoph Hellwig