From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3C2C4332F for ; Tue, 4 Jan 2022 08:01:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB6AF6B007D; Tue, 4 Jan 2022 03:01:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3FED6B007E; Tue, 4 Jan 2022 03:01:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908D66B0080; Tue, 4 Jan 2022 03:01:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 7B2BD6B007D for ; Tue, 4 Jan 2022 03:01:48 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5514C9094F for ; Tue, 4 Jan 2022 08:01:47 +0000 (UTC) X-FDA: 78991860654.14.9C40909 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id A2E424000A for ; Tue, 4 Jan 2022 08:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NfqD8G8M1+S5ehQHPWMYrcQSP6VKs29olySj7XNut6o=; b=a8ay7SfKgM/3vdPMQ/wsRXAKEj jrcxTV64s4HhkMt458LIeTDWmw53i7bzLEZizuhIbXci38zXb7JM5xi5WeaoaORwW0TBL31ircbjq uULp4YuywPa4B71buXhtmCO1ZLNibqJA4YBKpiwWLy6TLXiP+M55mQBjpkWKU6rfw+6o5U928Q1aC 1ManB/2vYCuQ2YgHTM5ssq6xOZ5cedCkm8qbAjHl5gtiY+W5Mkb1Se1BEHn+fYoifNfu7JwB71ZFh JjFr0YKf+A1Qu0jqRegVQeyxu3Lw3JDb/ZkFJmKZLBgvmcXuE983hYSbesOm5m6Byv8K5Mxu7x7eW 4rGZISsQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4elN-00AaPM-Eh; Tue, 04 Jan 2022 08:01:45 +0000 Date: Tue, 4 Jan 2022 00:01:45 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Andrew Morton Subject: Re: [PATCH 02/17] mm: Add folio_pincount_available() Message-ID: References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102215729.2943705-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A2E424000A X-Stat-Signature: 4ebanb9165xsut9s69k5dywtwi3tgmrt Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=a8ay7SfK; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e6cc8b46eea779d11ede+6708+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1641283305-990998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 09:57:14PM +0000, Matthew Wilcox (Oracle) wrote: > -static inline bool hpage_pincount_available(struct page *page) > +static inline bool folio_pincount_available(struct folio *folio) > { > /* > - * Can the page->hpage_pinned_refcount field be used? That field is in > + * Can the folio->hpage_pinned_refcount field be used? That field is in > * the 3rd page of the compound page, so the smallest (2-page) compound > * pages cannot support it. > */ > + return folio_order(folio) > 1; > +} Maybe convert the comment into a kerneldoc one? Otherwise looks good: Reviewed-by: Christoph Hellwig