From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20029C433F5 for ; Mon, 3 Jan 2022 07:51:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72B9A6B0072; Mon, 3 Jan 2022 02:51:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DB776B0073; Mon, 3 Jan 2022 02:51:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C9E06B0074; Mon, 3 Jan 2022 02:51:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 4FBF36B0072 for ; Mon, 3 Jan 2022 02:51:28 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0A5FF8D6E8 for ; Mon, 3 Jan 2022 07:51:28 +0000 (UTC) X-FDA: 78988205856.28.38155A5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 4BF05100003 for ; Mon, 3 Jan 2022 07:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N70+f5ukNUqMHlWzcDiVN5mc1EisTttVBGA9o2wFp4U=; b=tn1SzcMwXgNRLH/GY9jpXdR5+F i5YE+DmO7f2iHuc8ad+ltzpbS6aZa2l1E/hSi0hp3g0k/uVzDTefZWfLPBGPQJuEfi8Ez0xAhto7F 7fcmRwTg8qc0xJ+bV7Y9iZSSYwg7gcY76oCKn11oiy+WQbG3ZdrbzxMmNLt2mjnmPbW5kgzYSnPm1 jygxextSb4rq8tpCuW/sp83bLjYowg5UfJ+QcFK42OZlDXCbNa5+j85fxyoZ/jPTtLYj4VVReOLHY w0PnrGchNXx6Fhv80K+TxXNR/awtpOpqojgrjMLwgbaU8FbdLmVK4pfMYAnOlZRxLxpHpM1hQblm6 wmBJkKqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4I7h-008X4P-IW; Mon, 03 Jan 2022 07:51:17 +0000 Date: Sun, 2 Jan 2022 23:51:17 -0800 From: Christoph Hellwig To: Hugh Dickins Cc: Matthew Wilcox , Andrew Morton , Christoph Hellwig , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH next 1/3] truncate,shmem: Fix data loss when hole punched in folio Message-ID: References: <43bf0e3-6ad8-9f67-7296-786c7b3b852f@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43bf0e3-6ad8-9f67-7296-786c7b3b852f@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4BF05100003 X-Stat-Signature: rpoxa81yrxx73hzd4pwxs8xhjgpxig5t Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tn1SzcMw; spf=none (imf14.hostedemail.com: domain of BATV+81571d24d82b838d311c+6707+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+81571d24d82b838d311c+6707+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1641196285-974583 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 02, 2022 at 05:32:28PM -0800, Hugh Dickins wrote: > > + same_folio = (lstart >> PAGE_SHIFT) == (lend >> PAGE_SHIFT); Should this move to the else branch? Same for the other copy of this code. Otherwise this looks sane.