From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B50F9C433FE for ; Wed, 12 Jan 2022 10:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21FC46B0138; Wed, 12 Jan 2022 05:32:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CF266B0139; Wed, 12 Jan 2022 05:32:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BEB46B013A; Wed, 12 Jan 2022 05:32:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id ED8D76B0138 for ; Wed, 12 Jan 2022 05:31:59 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ACD30181E2529 for ; Wed, 12 Jan 2022 10:31:59 +0000 (UTC) X-FDA: 79021269558.18.D1A9870 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf25.hostedemail.com (Postfix) with ESMTP id 5D413A000E for ; Wed, 12 Jan 2022 10:31:59 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 347B21F461; Wed, 12 Jan 2022 10:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1641983518; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EZgKoHTkYozkeRvOASqvTf69IaXwtK5eJNoCLH3AhbI=; b=sanr4+/wNNMdO7ubzNxEAwyQj+vXii4/Tvu1+l3/Jvg+MJQZelEeBMZWNYSwkFPUJ8diEZ EyIbzejfDJPUj5HKVis1EWWBt8y6/TB9jz76pZOT2tL1HkmEJ8doGJf7TcY4wZZTL/SiCA AcQLqOB2y7cJjIJAjfTV559SuUS++bg= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id BB99CA3B85; Wed, 12 Jan 2022 10:31:57 +0000 (UTC) Date: Wed, 12 Jan 2022 11:31:57 +0100 From: Michal Hocko To: Yu Zhao Cc: Mike Rapoport , Andrew Morton , Linus Torvalds , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Konstantin Kharlamov Subject: Re: [PATCH v6 8/9] mm: multigenerational lru: user interface Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> <20220104202227.2903605-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5D413A000E X-Stat-Signature: fmpepfrr8hjcbhrfq9s5sfm8xjcrb75p Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="sanr4+/w"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-HE-Tag: 1641983519-55471 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 12-01-22 01:35:52, Yu Zhao wrote: [...] > But I saw people not following this practice, and I'm also tempted to > do so. Can anybody remind me whether it's considered a bad practice to > have code changes and Kconfig changes in the same patch? If you want to have the patch series bisectable then it is preferable to add kconfig options early so that the code is enabled in the respective steps. Sometimes that can be impractical though (e.g. when the feature is incomplete at that stage). -- Michal Hocko SUSE Labs