From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0305DC433F5 for ; Tue, 11 Jan 2022 08:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 991386B0073; Tue, 11 Jan 2022 03:41:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 940FE6B0074; Tue, 11 Jan 2022 03:41:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8573D6B0075; Tue, 11 Jan 2022 03:41:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 794446B0073 for ; Tue, 11 Jan 2022 03:41:34 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3F72B181E18BF for ; Tue, 11 Jan 2022 08:41:34 +0000 (UTC) X-FDA: 79017362508.03.4800040 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id BFF9320012 for ; Tue, 11 Jan 2022 08:41:33 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BFA131F3B8; Tue, 11 Jan 2022 08:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1641890492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qrf8PNeNEVsS9AToHTl2fRoEbnuL360momcCs7MV/Sg=; b=ecugM7jQuj/2S3JHjsuidBQqPtwwEX4TGWpLLZt+mGtoKTsyv7KiL/V8T3ykq5QhPyepzb avM3gfZF8eubZ8zI8PtyljwP4pGNP2V5BBtD/C/V2DMnKk0HmkHhlMqJ0pODA7hATwq7RX +ZE+8TsvtCdZWhxr/eNU6TbpGutY1UQ= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8C68DA3B8E; Tue, 11 Jan 2022 08:41:32 +0000 (UTC) Date: Tue, 11 Jan 2022 09:41:32 +0100 From: Michal Hocko To: Wei Yang Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on allocation Message-ID: References: <20220111010302.8864-1-richard.weiyang@gmail.com> <20220111010302.8864-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111010302.8864-2-richard.weiyang@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BFF9320012 X-Stat-Signature: 1pa3qfcut63dx58ssy17koi4soeqoiwh Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ecugM7jQ; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1641890493-971528 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-01-22 01:03:00, Wei Yang wrote: > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang Acked-by: Michal Hocko > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 11715f7323c0..a504616f904a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > } > > lruvec_init(&pn->lruvec); > - pn->usage_in_excess = 0; > - pn->on_tree = false; > pn->memcg = memcg; > > memcg->nodeinfo[node] = pn; > -- > 2.33.1 -- Michal Hocko SUSE Labs