From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26178C433EF for ; Thu, 13 Jan 2022 02:00:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3116B0072; Wed, 12 Jan 2022 21:00:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 252E46B0073; Wed, 12 Jan 2022 21:00:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F4546B0074; Wed, 12 Jan 2022 21:00:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 0142D6B0072 for ; Wed, 12 Jan 2022 21:00:56 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AF388944CF for ; Thu, 13 Jan 2022 02:00:56 +0000 (UTC) X-FDA: 79023610512.09.E784FA1 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf20.hostedemail.com (Postfix) with ESMTP id AB0B61C0006 for ; Thu, 13 Jan 2022 02:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642039255; x=1673575255; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yKzcsErOlaAl5BAEg+mgbVtS8VvF2vEozWEkVuvjUuM=; b=Avhcz6IH5a5O5jQUNGfE5HmJo9+OMSQ/v9p7GT7K1tY3y1Q9gB5Aj5sl SIYCBDS162qp/GaAmOmclxmJgeAz4oc3oSIsgBkR3XNqSWlyOsPXx63WO FZO5MWBm10n9E4IIfTO7YdP23GniqfY8GZtrEwzPWEBgpi2GblFQyNZ8q Swylpm3PGUaxW9etkEhc6SoKm6aObeW5w1kMQsDm3dE1rKtCgbccqo8X0 OOKudw5rejwgHIcbK8Tgrioc+hZeuP17QXfaZ8+4fl+ge4crLUUb+ZncB goyXtjrYWvrNeThg17Hvcmgcoggwn0tTyaDkiLUkeo+3oPjMvV8AYAIjk w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="243702025" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="243702025" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:00:53 -0800 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="576780006" Received: from agluck-desk2.sc.intel.com (HELO agluck-desk2.amr.corp.intel.com) ([10.3.52.146]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:00:53 -0800 Date: Wed, 12 Jan 2022 18:00:51 -0800 From: "Luck, Tony" To: Naoya Horiguchi Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Youquan Song , Naoya Horiguchi Subject: Re: [PATCH] mm/hwpoison: Fix error page recovered but reported "not recovered" Message-ID: References: <20220107194450.1687264-1-tony.luck@intel.com> <20220112121145.GA889650@u2004> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220112121145.GA889650@u2004> X-Rspamd-Queue-Id: AB0B61C0006 X-Stat-Signature: aem7grjqp6u4jico9f7ab4agz1163wh9 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Avhcz6IH; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf20.hostedemail.com: domain of tony.luck@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=tony.luck@intel.com X-Rspamd-Server: rspam03 X-HE-Tag: 1642039255-885033 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 12, 2022 at 09:11:45PM +0900, Naoya Horiguchi wrote: > On Fri, Jan 07, 2022 at 11:44:50AM -0800, Tony Luck wrote: > > From: Youquan Song > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 14ae5c18e776..4c9bd1d37301 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -707,8 +707,10 @@ static int kill_accessing_process(struct task_struct *p, unsigned long pfn, > (void *)&priv); > if (ret == 1 && priv.tk.addr) > kill_proc(&priv.tk, pfn, flags); > + else > + ret = 0; > mmap_read_unlock(p->mm); > - return ret ? -EFAULT : -EHWPOISON; > + return ret > 0 ? -EHWPOISON : -EFAULT; > } > > static const char *action_name[] = { Yes. This fixes the problem (and your explanation helped me understand this code better). Fell free to take any words you need from the original patch comment and switch to: Reported-by: Youquan Song Thanks for looking (and fixing!) -Tony