From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636BCC433FE for ; Thu, 23 Dec 2021 14:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1F366B007E; Thu, 23 Dec 2021 09:33:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE686B0081; Thu, 23 Dec 2021 09:33:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBE396B0083; Thu, 23 Dec 2021 09:33:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id BA8736B007E for ; Thu, 23 Dec 2021 09:33:02 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7638C8A3F8 for ; Thu, 23 Dec 2021 14:33:02 +0000 (UTC) X-FDA: 78949301004.08.46D1C87 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 8B356C004D for ; Thu, 23 Dec 2021 14:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QcDVR64BxqDwzqoahP33c28v+/sUsP60ObvEvRp3VzA=; b=OOmPCM8DjrglabG0TzcBn8t/DE yLPzvuSs69nlkWcn7IiI0nKudl7xEnkujpIuhWub11koR3NgN7wE4JBkwpKL0N3PZijdYiXiNg2Hh iihpLaPevCwZ/EpqrQOzmA6x37/i0VJGFeS6p47nHwGWgTWXK47HW4vI5RTHpmG+z9hox/aMwKz54 VMFHrz4TqEeV4a8HFHbGsv4nPb/DaUAB69+alR6+AoIRGlAMXumcidykImF5QiDhV+Ixk71+dZiuG ago1OviBVc+MJ6slEYa6Pzon22xVkmXyNINqP80qcd3a/J4CZTIWoMQa7tm6v8264jwZiRUtp1Lfk kTV1Y5yA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0P9P-004Kvp-1f; Thu, 23 Dec 2021 14:32:59 +0000 Date: Thu, 23 Dec 2021 14:32:59 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/48] filemap: Add folio_put_wait_locked() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8B356C004D X-Stat-Signature: 78k1o9qm6nawbg7e3oou76kz41ybxmpe Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OOmPCM8D; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1640269981-33195 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 22, 2021 at 11:00:40PM -0800, Christoph Hellwig wrote: > > -int put_and_wait_on_page_locked(struct page *page, int state); > > +int folio_put_wait_locked(struct folio *folio, int state); > > This could actually move to mm/internal.h. It doesn't have any callers outside mm/ for now (and actually a couple of the callers are going away), but conceptually it's part of the lock_page() family of functions. Some other places might benefit from waiting without the reference held.