From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E444CC433EF for ; Thu, 23 Dec 2021 14:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40E776B007B; Thu, 23 Dec 2021 09:31:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BDD06B007E; Thu, 23 Dec 2021 09:31:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ACFA6B0081; Thu, 23 Dec 2021 09:31:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 191D16B007B for ; Thu, 23 Dec 2021 09:31:33 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C369789560 for ; Thu, 23 Dec 2021 14:31:32 +0000 (UTC) X-FDA: 78949297224.15.B6B8C2A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 515204002D for ; Thu, 23 Dec 2021 14:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z1eiMI4jxOj7ZcVKGJ+SsGYdaWD045y5IWQK69kPbEw=; b=p8knSI2G3hsJCE+YZgPkHeSAHv 0yGoq7Jk+7qtmkXt5XHUqiF2lJfEh4UVNqlrbulzR5GGYRkmWli5BcOvHryJsS9K1t5UGahLxngzH mUKQvOa8cxgMxMPlkuvH4+4ul4sMjqCgih/8gQVdbDCJ2PZzSShLKNrrQ8koUpMHayeK47v/fH7Zo gil7s0b2/x+FE/jrbwgbskSQ7J/9vCevZ5//OwuwDm4A90Pr9OQEao9rKjxk5LQMTJZr7YKd/YzAu 8qQey8LJmkjXJz07BWRdYdQeSG3WhYh8SkiNu4zhQDLk0jkVedMdZt9DiS5yMSP+tJ84AlhGknxI4 xSn2wzbg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0P7v-004KsY-Nx; Thu, 23 Dec 2021 14:31:27 +0000 Date: Thu, 23 Dec 2021 14:31:27 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, David Howells Subject: Re: [PATCH 07/48] iov_iter: Convert iter_xarray to use folios Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 515204002D X-Stat-Signature: oxaykexrmkq5zhxkyaojmn3r8ahbjtht Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=p8knSI2G; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1640269889-193974 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 22, 2021 at 10:57:28PM -0800, Christoph Hellwig wrote: > > + size_t offset = offset_in_folio(folio, start + __off); \ > > + if (xas_retry(&xas, folio)) \ > > continue; \ > > + if (WARN_ON(xa_is_value(folio))) \ > > break; \ > > + if (WARN_ON(folio_test_hugetlb(folio))) \ > > break; \ > > + while (offset < folio_size(folio)) { \ > > Nit: I'd be tempted to use a for loop on offset here. Dave, this is your code originally ... any opinions? > Otherwise looks good: > > Reviewed-by: Christoph Hellwig