From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD79C433FE for ; Thu, 23 Dec 2021 07:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8C636B0073; Thu, 23 Dec 2021 02:16:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3B396B0074; Thu, 23 Dec 2021 02:16:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92B9A6B0075; Thu, 23 Dec 2021 02:16:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 84AD66B0073 for ; Thu, 23 Dec 2021 02:16:59 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 45A58181AC9C6 for ; Thu, 23 Dec 2021 07:16:59 +0000 (UTC) X-FDA: 78948202158.26.1617EC8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id B38EC1C004A for ; Thu, 23 Dec 2021 07:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M62TrzwRxO351s13wL0W7IRgVmliiZdiXgK9u1w5zLI=; b=laxybFTQwPErh+ckgr+McBjvJH CJ02rIf7LrdzZLXG6ZCfYTCJFQhlOJoCPvQ7Y7oMTHo27ciHlg0ybnbhck/74yXhGOzdCeuR0OhpU pFng2I75By+SLrLTfRm1MoDsDpHzJKqTsaXazSt2IrffgUNX9k2s9MGmho2U21myCNf/AR9+qYKKj TrqkX26otvvfZn0pSith0coh79jKMQADUyOES5nZHGmZcvD+pTeCA64tOHR/VJY4H1QNBgdHnWJWa IDK3G0YttIngRgX8Hp6fLGh3K0LLBVkAYHlKLbc+h5RA1L3yCiVkMzubE9eksQV1yogIAONH+mbkr k74/0APw==; Received: from 089144208226.atnat0017.highway.a1.net ([89.144.208.226] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0ILQ-00BxkJ-EV; Thu, 23 Dec 2021 07:16:57 +0000 Date: Thu, 23 Dec 2021 08:16:52 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 18/48] filemap: Convert filemap_read_page to take a folio Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-19-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-19-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B38EC1C004A X-Stat-Signature: b9o1f1azefqp58g7gsg5fiezrtyc7cya Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=laxybFTQ; spf=none (imf20.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1640243813-682199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 04:22:26AM +0000, Matthew Wilcox (Oracle) wrote: > One of the callers already had a folio; the other two grow by a few > bytes, but filemap_read_page() shrinks by 50 bytes for a net reduction > of 27 bytes. Looks good, Reviewed-by: Christoph Hellwig