From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168A8C433F5 for ; Tue, 21 Dec 2021 13:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917366B0071; Tue, 21 Dec 2021 08:21:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6426B0073; Tue, 21 Dec 2021 08:21:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B4C16B0074; Tue, 21 Dec 2021 08:21:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 6B83E6B0071 for ; Tue, 21 Dec 2021 08:21:36 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 290B5180E4EEB for ; Tue, 21 Dec 2021 13:21:36 +0000 (UTC) X-FDA: 78941863392.09.83DD73A Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf30.hostedemail.com (Postfix) with ESMTP id 92CCE80032 for ; Tue, 21 Dec 2021 13:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B/oDToJjF+9MzhiotE5SBO6bEHgGlfnze/KNPpAHsCg=; b=SfQyc19jT/JZHSai2UnntFDszE dHXubqLDm2OtdY+7lByHgwHoqZv5IkGbAbEqeONpa6hu5tS8N2Fk/5x1B+aB4TlkCHoY7FQ4fKb5d fCmrRWtxPOcJVp2OyTmyMq5mxuavxsyrcrhutLwB0905JlF6NwGi1Eq8qOC0SQqV+23s3ezCVK8GQ qdAaPpEM23eAPsR/2hqZI7bJ32V+qYe5eixsRzCGEviLjVtEvoBkHH2Lp+uXWD0AZpVxY4hjl2bhR cqojP2dzXmKesKtM+SNwap1S7kIA7njOKiAiDTI2Aa3THkrBARxKYFudRpw4uZMgZ/3TADlJBvQo6 TbsMRdmA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzf55-002jwx-KO; Tue, 21 Dec 2021 13:21:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D41533002AE; Tue, 21 Dec 2021 14:21:26 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BE30C206E66FD; Tue, 21 Dec 2021 14:21:26 +0100 (CET) Date: Tue, 21 Dec 2021 14:21:26 +0100 From: Peter Zijlstra To: Nikita Yushchenko Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Catalin Marinas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Arnd Bergmann , Sam Ravnborg , x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, kernel@openvz.org Subject: Re: [PATCH/RFC v2 1/3] tlb: mmu_gather: introduce CONFIG_MMU_GATHER_TABLE_FREE_COMMON Message-ID: References: <20211218185205.1744125-1-nikita.yushchenko@virtuozzo.com> <20211218185205.1744125-2-nikita.yushchenko@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211218185205.1744125-2-nikita.yushchenko@virtuozzo.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 92CCE80032 X-Stat-Signature: of58widi3hmbmtp6gxzs1wmddaia3ayk Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=SfQyc19j; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-HE-Tag: 1640092895-409282 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 18, 2021 at 09:52:04PM +0300, Nikita Yushchenko wrote: > For architectures that use free_page_and_swap_cache() as their > __tlb_remove_table(), place that common implementation into > mm/mmu_gather.c, ifdef'ed by CONFIG_MMU_GATHER_TABLE_FREE_COMMON. > > Signed-off-by: Nikita Yushchenko > --- > arch/Kconfig | 3 +++ > arch/arm/Kconfig | 1 + > arch/arm/include/asm/tlb.h | 5 ----- > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/tlb.h | 5 ----- > arch/x86/Kconfig | 1 + > arch/x86/include/asm/tlb.h | 14 -------------- > include/asm-generic/tlb.h | 5 +++++ > mm/mmu_gather.c | 10 ++++++++++ > 9 files changed, 21 insertions(+), 24 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index d3c4ab249e9c..9eba553cd86f 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -415,6 +415,9 @@ config HAVE_ARCH_JUMP_LABEL_RELATIVE > config MMU_GATHER_TABLE_FREE > bool > > +config MMU_GATHER_TABLE_FREE_COMMON > + bool I don't like that name... The point isn't that it's common, the point is that the page-table's are backed by pages.