linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH/RFC v2 1/3] tlb: mmu_gather: introduce CONFIG_MMU_GATHER_TABLE_FREE_COMMON
       [not found] ` <20211218185205.1744125-2-nikita.yushchenko@virtuozzo.com>
@ 2021-12-21 13:21   ` Peter Zijlstra
  2021-12-21 15:42     ` Nikita Yushchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Zijlstra @ 2021-12-21 13:21 UTC (permalink / raw)
  To: Nikita Yushchenko
  Cc: Will Deacon, Aneesh Kumar K.V, Andrew Morton, Nick Piggin,
	Catalin Marinas, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
	Dave Hansen, Arnd Bergmann, Sam Ravnborg, x86, linux-kernel,
	linux-arch, linux-mm, kernel

On Sat, Dec 18, 2021 at 09:52:04PM +0300, Nikita Yushchenko wrote:
> For architectures that use free_page_and_swap_cache() as their
> __tlb_remove_table(), place that common implementation into
> mm/mmu_gather.c, ifdef'ed by CONFIG_MMU_GATHER_TABLE_FREE_COMMON.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
> ---
>  arch/Kconfig                 |  3 +++
>  arch/arm/Kconfig             |  1 +
>  arch/arm/include/asm/tlb.h   |  5 -----
>  arch/arm64/Kconfig           |  1 +
>  arch/arm64/include/asm/tlb.h |  5 -----
>  arch/x86/Kconfig             |  1 +
>  arch/x86/include/asm/tlb.h   | 14 --------------
>  include/asm-generic/tlb.h    |  5 +++++
>  mm/mmu_gather.c              | 10 ++++++++++
>  9 files changed, 21 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/Kconfig b/arch/Kconfig
> index d3c4ab249e9c..9eba553cd86f 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -415,6 +415,9 @@ config HAVE_ARCH_JUMP_LABEL_RELATIVE
>  config MMU_GATHER_TABLE_FREE
>  	bool
>  
> +config MMU_GATHER_TABLE_FREE_COMMON
> +	bool

I don't like that name... The point isn't that it's common, the point is
that the page-table's are backed by pages.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH/RFC v2 1/3] tlb: mmu_gather: introduce CONFIG_MMU_GATHER_TABLE_FREE_COMMON
  2021-12-21 13:21   ` [PATCH/RFC v2 1/3] tlb: mmu_gather: introduce CONFIG_MMU_GATHER_TABLE_FREE_COMMON Peter Zijlstra
@ 2021-12-21 15:42     ` Nikita Yushchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Nikita Yushchenko @ 2021-12-21 15:42 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Will Deacon, Aneesh Kumar K.V, Andrew Morton, Nick Piggin,
	Catalin Marinas, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
	Dave Hansen, Arnd Bergmann, Sam Ravnborg, x86, linux-kernel,
	linux-arch, linux-mm, kernel

>> +config MMU_GATHER_TABLE_FREE_COMMON
>> +	bool
> 
> I don't like that name... The point isn't that it's common, the point is
> that the page-table's are backed by pages.

What is a better name?

MMU_GATHER_TABLE_FREE_PAGES?

MMU_GATHER_TABLE_FREE_PAGES_BACKED?

Nikita



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-21 15:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211218185205.1744125-1-nikita.yushchenko@virtuozzo.com>
     [not found] ` <20211218185205.1744125-2-nikita.yushchenko@virtuozzo.com>
2021-12-21 13:21   ` [PATCH/RFC v2 1/3] tlb: mmu_gather: introduce CONFIG_MMU_GATHER_TABLE_FREE_COMMON Peter Zijlstra
2021-12-21 15:42     ` Nikita Yushchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox