From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBB9C433F5 for ; Tue, 21 Dec 2021 12:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C41EB6B0071; Tue, 21 Dec 2021 07:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF2186B0073; Tue, 21 Dec 2021 07:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB98B6B0074; Tue, 21 Dec 2021 07:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 9897C6B0071 for ; Tue, 21 Dec 2021 07:12:04 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 54FA587C82 for ; Tue, 21 Dec 2021 12:12:04 +0000 (UTC) X-FDA: 78941688168.10.D970025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 79B2920027 for ; Tue, 21 Dec 2021 12:11:55 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id s1so21117187wra.6 for ; Tue, 21 Dec 2021 04:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jfaFJc8Cz1U41Grmp9dApUf6heZ4GsGx9TaK2/L8KJ8=; b=rXXpkxvAqlZJxXII9t13lJWwFpQKDr53BPSUm8rox7gb1xTX6knSAWASZTBOc7e6K9 hcsTRynp1v+qKkg/KNNPj5x05hMhq5KLcmCIq8GNT9QG0a8vXuIJ9dfTHiXNgMBp7JqC pB4N0PdccOgqjel8LDV75Ul9+1SNn4bo4nWBKcfr087O43y9Ppn4PZn67Q9JZPa/B9dj oeSbp1XC/YbNqd97d1kXspb6j2Pr4brrLgLCo0RoBQms5enF25lG+otJ4BtdKlzgn/sW 1HPyaNkru7kq13q/7lfguzH4RSLIo+JiQ/muUHIcfHyZFcvk3QOt80LvR1Z/Rd87ElYM Ct7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jfaFJc8Cz1U41Grmp9dApUf6heZ4GsGx9TaK2/L8KJ8=; b=FlBnxQwBWV1Mb+PJ9/rUdFHxsbkQN3lnvJvCD4opWNvCtlQoL6hk1xtAafjrWjGnsX zQNNjevC5GUA1qZlKx5cpMOImJdX2rHDVfOB+DHDrZo9BTmfVUEPAePcAqZx392RpDOk 5kK6CpcEPmsyAwU8lr5VXvCXz8aMq1Z1uEjlDCDO1J7f03fC/6h2HqUI3ApnjtXIwVkn GI3wQ27E4jU0oCQS0cqwHNBcdiWBXX5QOeFSRat93DYdGxYSvCUNjOoxfpIH0F1PdHWV oPVOggjK1j7O7gRD57RIp4B/no1pARzJ65HcDKpoT34ZE0VonktofB/qrlZXcDE1iXgU wI5g== X-Gm-Message-State: AOAM533JeiWRFCh1Fqg9TTzDgAzUuXOA8dD/qHfRplA3tqE6alzuTh+m dTJ0adCOdHRkL9YCE7G3uiaeRA== X-Google-Smtp-Source: ABdhPJz82HUVXY+qdDadDZ4std231gMaciHwyCd375yzBVc79K02MakZ5rf/njE7fI+bDkHQwWCg8Q== X-Received: by 2002:adf:f54e:: with SMTP id j14mr2402039wrp.442.1640088722221; Tue, 21 Dec 2021 04:12:02 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:87ff:799:2072:8808]) by smtp.gmail.com with ESMTPSA id o12sm17642260wrv.76.2021.12.21.04.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 04:12:01 -0800 (PST) Date: Tue, 21 Dec 2021 13:11:56 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH mm v4 29/39] kasan, page_alloc: allow skipping memory init for HW_TAGS Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 79B2920027 X-Stat-Signature: dr1stzair4pi919u7g8yzzk3mzyxdt8g Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rXXpkxvA; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1640088715-494517 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov [...] > +static inline bool should_skip_init(gfp_t flags) > +{ > + /* Don't skip if a software KASAN mode is enabled. */ > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > + return false; > + > + /* Don't skip, if hardware tag-based KASAN is not enabled. */ > + if (!kasan_hw_tags_enabled()) > + return false; Why is the IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check above required? Isn't kasan_hw_tags_enabled() always false if one of those is configured?