From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C611DC433EF for ; Thu, 16 Dec 2021 13:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF7E56B0078; Thu, 16 Dec 2021 08:17:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6016B007B; Thu, 16 Dec 2021 08:17:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6E146B007D; Thu, 16 Dec 2021 08:17:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id C8BA46B0078 for ; Thu, 16 Dec 2021 08:17:28 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8E744181AEF09 for ; Thu, 16 Dec 2021 13:17:18 +0000 (UTC) X-FDA: 78923708556.30.4DB1BD1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 800551C000D for ; Thu, 16 Dec 2021 13:17:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6957BB8241D; Thu, 16 Dec 2021 13:17:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D115EC36AE0; Thu, 16 Dec 2021 13:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1639660635; bh=XbBRQDo3AW/RlwAsMdjxCkJfR9JW1oi5CoKZzO0S6yQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WOq1Y6kiIMdfkT4ZD/VCz+ampS41gbsPMlKTiMGrc5z6tFwUbdbMmOBxm/5z/jfyH g/x0jdAjp1a/xpMEQaJpOJ7+p1yJSgV9VmxoOpyqB+8wp4oOhFBKCssk16zoQmFez4 Yxq3JVzuUXd4LHJKijogXEeitY9CAXb6aF8QGoyI= Date: Thu, 16 Dec 2021 14:17:12 +0100 From: Greg KH To: Qi Zheng Cc: akpm@linux-foundation.org, rafael@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com Subject: Re: [PATCH 2/2] mm: reimplement si_mem_available() Message-ID: References: <20211216124655.32247-1-zhengqi.arch@bytedance.com> <20211216124655.32247-3-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211216124655.32247-3-zhengqi.arch@bytedance.com> Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=WOq1Y6ki; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 800551C000D X-Stat-Signature: rx7kgebedn9z3tzi5jnpzuzfzak8b6w1 X-HE-Tag: 1639660635-740280 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 16, 2021 at 08:46:55PM +0800, Qi Zheng wrote: > Reimplement si_mem_available() by reusing si_mem_available_node(). That says what you did, but not why. Why are you doing this? And what does it have to do with patch 1/2? thanks, greg k-h