From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCDCC433EF for ; Wed, 15 Dec 2021 23:39:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D2716B0071; Wed, 15 Dec 2021 18:39:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 459C16B0073; Wed, 15 Dec 2021 18:39:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25EC06B0074; Wed, 15 Dec 2021 18:39:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 10B106B0071 for ; Wed, 15 Dec 2021 18:39:04 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C33B58249980 for ; Wed, 15 Dec 2021 23:38:53 +0000 (UTC) X-FDA: 78921646146.06.8DC4B1D Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by imf09.hostedemail.com (Postfix) with ESMTP id D22E6140016 for ; Wed, 15 Dec 2021 23:38:49 +0000 (UTC) Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFLifJB008483; Wed, 15 Dec 2021 15:38:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=facebook; bh=FISMclEalm7kRVdN9oOm4Xk4Dtn0W9Br+NPCqWkjADQ=; b=Wy7dJd/hHD0a3/3lPONEkmkNHCBtUIfn4N2q07ittQlvv6HrAbw1hiWMK3O76FNXzNqj EUF+hFHeii4mpY3yLUffGd3MAptl6j21ahCdjkSOhb75Cr8IbKkDVq45XtdM8yoHIvpA HS0JIKaCb3rOrXxK/2VTlrvo5fV8jKWnqlU= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3cy7crga64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 15 Dec 2021 15:38:28 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.36.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 15 Dec 2021 15:38:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LrRrjqAEWM7+2qrlUBRv4olSmlElAM+8bI33aCqsY/sl9zFpUUSPR2dAjqvJkmhOY1Dh+x+CcVv9Uptd9/rvjfl8lEcvRW+keddAGwqGRQrDciTOqHpqGZMZ3FiP8xywxysS6NPNaKhTE0n5WJFlZf6g9uVTLev477VY5bnu6Ey0petwr7wHJsxZ8MaEP6DRxGmhshrvj9QWbPMq+bPQ24KRLE66TsooKEL5bXdCTMW2qm7hE8jyzMUM6UcMntAUumcG/RWhC7DGmzMysfKG+i49S1l4dpAxmfXKF9Dkf6hiIoIHPsQkCwhx+KPgY3tHA5c1tLnOJ+9qamFuYltJew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FISMclEalm7kRVdN9oOm4Xk4Dtn0W9Br+NPCqWkjADQ=; b=QTxhY5jDzBj8SKjFeRJTwbrNUdt3lOr/5ZwNfO/aVc2dwyMoohuRVBARmmVWa1VFb/9SUlpevy2c3jTj7OMImzPM9rwmUUEwViEhgO72fyOWiSA+f1zmgGq1sFpm3QlIaFXZ23r/aGGB5pA0rZbChSVXI++dEYg4zShWqcxUeo8lE/lihNS7Ld7ibbTrZwBvjBvJpDZ0n1AxUZYIkVK/Qg7hd+Muz2T5om3goyIUE9QCfjrtxuQYCIWl6Ma7xcOLacuy5d7XxB27F87GnORUfGSLZO0HhZY0RwLygUgo2SUoVSNQ+bpiZUQRW4FFZnBffxdHcC7TY8SyuQKCcYBScA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) by BYAPR15MB2279.namprd15.prod.outlook.com (2603:10b6:a02:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Wed, 15 Dec 2021 23:38:25 +0000 Received: from BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::8584:55d7:8eae:9463]) by BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::8584:55d7:8eae:9463%7]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021 23:38:25 +0000 Date: Wed, 15 Dec 2021 15:38:19 -0800 From: Roman Gushchin To: Vlastimil Babka CC: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , , Andrew Morton , , Alexander Potapenko , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , , Dave Hansen , David Woodhouse , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , , Joerg Roedel , Johannes Weiner , Julia Lawall , , Lu Baolu , Luis Chamberlain , Marco Elver , Michal Hocko , Minchan Kim , Nitin Gupta , Peter Zijlstra , Sergey Senozhatsky , Suravee Suthikulpanit , Thomas Gleixner , Vladimir Davydov , Will Deacon , , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH v2 00/33] Separate struct slab from struct page Message-ID: References: <20211201181510.18784-1-vbabka@suse.cz> <4c3dfdfa-2e19-a9a7-7945-3d75bc87ca05@suse.cz> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW4PR04CA0380.namprd04.prod.outlook.com (2603:10b6:303:81::25) To BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13123b19-8e1c-4acf-988e-08d9c023fd34 X-MS-TrafficTypeDiagnostic: BYAPR15MB2279:EE_ X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m4ZpujmxJue4PB3Ip6Xbd//u7zrtULBvySXMnFhCy/bxY2V44Oi+1MLfShwg/rTgRotXD95dJ+yH+5Wb4W+QO/N+Tb8hiMWr2kqTC4vsA8VlEeVNhi1TybLx7n37rWRwTzKiJ5StFZSIZ+vDyzULSzM4Z3h8cOlbi44CS1hIDfayMak77VM2fefl0OSGO2yQLIgmJvlu0hW7lrIukBDd3TMmaQ9gVdrw3CilgMrkeqx6AHitFnmzc5yxIFlQG5wz3Dnd8BgAURKlOofcGlYq4sudGJ9MEqJE05D2/Sq6skSYNNCd6nfOqIfPz2lUEPiCM6kOwLP40hRNDCSwTi0eqQ461CyQXFS36ER1ensxRLmbAh9hs5qc3Km0zgWdAhSNvjMJHEeWULnZrqYT1gf0+pZBvx9jD6eshjHV8WAp41yxkJrJoh/uonIv5g/Qce9Jb8yQXERdgNTTbkTH1+7gOhsTLbzAF4g+SbBw+N9nyDnsJzhtQeQvRE74L2KSd7up39HeqYHSA0d86nwgxGEbDe7QySjbOHkr+s6zp5PGPnDuevnEtH6N6htLhPxyLBioalHhCfFyYPk1fK+m/GJV+0xD00kkFiMRkHnAkRGsWW+ayjPKE+8hm1fl3YYFfrl3FRU1+Edi23nrdeU3EEJDSKrVdfpigCnbDzzlpnlzg1mOx6PHQ45elzx2+4V2lbY2sa2qzsUal4w8Os4Q0EABINnRiybdoKAfS4FgLXtZed0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(66476007)(7406005)(7416002)(966005)(6506007)(83380400001)(186003)(9686003)(53546011)(86362001)(66556008)(6512007)(4326008)(6486002)(5660300002)(54906003)(508600001)(8936002)(52116002)(38100700002)(316002)(8676002)(6666004)(6916009)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qHZbvZW3xZfg2H639D4oHo8GWNrKe7RzpHXjjcEw0j+ElSCeIy3fl1MCxgNp?= =?us-ascii?Q?fk5sRY28xqZojCGoVA2OwXBbUpXZP8UbvKxmV0wnjy9m81tGH5j193BXmdYn?= =?us-ascii?Q?htfxioVC8w6BGbOIEjLCh4f7zlmbPzwFXQ1gg2WRpopVJmfVhd1ULUuvCHYK?= =?us-ascii?Q?c0rNVL2i2bsSvsl/VznafJW/kmnHmUeQZ8ocQt9S/i1jCeE+qe+B9J1vzslq?= =?us-ascii?Q?co/UOLjOnSpoIirnO4XBxq6M4UZ660T+via+aO+4Uj7xigugP1tYcGsz0X9g?= =?us-ascii?Q?oIul2cP8V1zVRw5j5PMBB6TWxLcWUIHRDCiJET+UGqPVOmPbBcO/6NvoXl/a?= =?us-ascii?Q?jC7QLhLU4+uSl7Ma1NWuUS1YzWewM50jFpuYDVEnl4txL3rPYWp9zu8ITmbK?= =?us-ascii?Q?toc0ld9lwmjQqoTn2H7N8B9PWoy7owLZkS5QxLqOMzEWqsTzC/rvckH03pdZ?= =?us-ascii?Q?DnNswTpQ9SilQvEaas8K4qg7vppWK+80F40EZo8Gwoc75BLzYPTxbfq+V5GA?= =?us-ascii?Q?vCpXCDzulZDcQE2GeesTtV3EXgX2RLK1+YAJBX90nd37hEq7z4RMRjwiCXPP?= =?us-ascii?Q?M7uG8bGk39s5VNovmRnMg4EFZCguRRE0Ei4rDO84vU6xKbUl/35ACn9/K8qB?= =?us-ascii?Q?mMWPhzJeFs98/HF8RWup2z2FVt3YVv5KL/+Rj+WcB7xRy1SUh6G4UkVaG+YM?= =?us-ascii?Q?WQV4lE3NYTKSPlonZU2F2VCAZ6g5/n1xOK8ayGlpmm/gmzVRtKqPHFXnq0VR?= =?us-ascii?Q?JFAXEiNi03aMSZxXec1UiroKXieQYscQu9L9nxhO0LKkl0aN7rnC9o5s83S8?= =?us-ascii?Q?wL4u3mNJq7Pqh/A1eHNKulZcMyApzAB4V6ox6Hx8EKHjIsNq3Co7fxzHGLqf?= =?us-ascii?Q?TglOQj8mjz9RYHTaiN+E/lLglITwE4IOSm/cuVysIpRonDnzpBMTCk78fApt?= =?us-ascii?Q?6NytAINVY12obb60gkgGYqePBUJwIUPalzHvlSkqJdMbbREtqoN3pJOiCXzf?= =?us-ascii?Q?tLrZVXswMU64aHlu8wLVlhNKfHKfqN3OOTz4M93unzcMU7uKzn1MCRmnl9kf?= =?us-ascii?Q?VErEtN504qBgUwWVZ/tcjbZGv6+Y84nnRWenH1qryPK9FwCBTgWvNz1fk6yl?= =?us-ascii?Q?cbsSQXqDM6tFn7fVGKHRRPJ0iA4YrPTrKytavaMHZkcD/F+jVUuv8jkI/DNY?= =?us-ascii?Q?lZjv+ELSTt8Q7gBV8EZZQSPiOf7wwFiCmX7HHnR5zaZioH7MOSkG4eoaZi8J?= =?us-ascii?Q?9oTlTkahsfabDeHkC7dt4qFCmA18SdugdpRNTKoXg2vAgZrvbpO57Mo/8I2n?= =?us-ascii?Q?53VQ7Tm2AN7TGu5n6P5x6fk5SYYcUnRc+95Bvxk0I1/wVbI5YDQ+Mn7Agzz7?= =?us-ascii?Q?ncFMz8IHDDgYgO9cKTniF8MJ3ElWxjD273WRb7FYy/mKKqydE2zVF4ZXV5WA?= =?us-ascii?Q?rKjrSdTgx7AqPPq27Iy/FJsp56tw1xSbaQ5ozzmlQGjrRMg75tJ1LVIKmrMy?= =?us-ascii?Q?FaIT9l270YllC7GC+y+9Hf2WHu4p3Q8qOCn6kOaaoyBjXwXNp1syZ43momAk?= =?us-ascii?Q?VNW+U9q95MACyjogLny6yKqQNdIKEpw0/lJeAJ5k?= X-MS-Exchange-CrossTenant-Network-Message-Id: 13123b19-8e1c-4acf-988e-08d9c023fd34 X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 23:38:25.5981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 502OFXuYOCyoUZa0d1BI9xnQ4zLRydmx+XGfQHxIUkvtXXeTvKbVwlVWzBPZJ4BV X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2279 X-OriginatorOrg: fb.com X-Proofpoint-GUID: ejU5ABcSgpWPvL7_kP-E2zM79ngJWtJL X-Proofpoint-ORIG-GUID: ejU5ABcSgpWPvL7_kP-E2zM79ngJWtJL X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-15_13,2021-12-14_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 priorityscore=1501 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112150129 X-FB-Internal: deliver X-Rspamd-Queue-Id: D22E6140016 X-Stat-Signature: i88xattckjb5iaeaecribcggsgpqri6c Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b="Wy7dJd/h"; dmarc=pass (policy=reject) header.from=fb.com; spf=pass (imf09.hostedemail.com: domain of "prvs=19835c127b=guro@fb.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=19835c127b=guro@fb.com" X-Rspamd-Server: rspam11 X-HE-Tag: 1639611529-764793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 14, 2021 at 05:03:12PM -0800, Roman Gushchin wrote: > On Tue, Dec 14, 2021 at 01:57:22PM +0100, Vlastimil Babka wrote: > > On 12/1/21 19:14, Vlastimil Babka wrote: > > > Folks from non-slab subsystems are Cc'd only to patches affecting them, and > > > this cover letter. > > > > > > Series also available in git, based on 5.16-rc3: > > > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slab-struct_slab-v2r2 > > > > Pushed a new branch slab-struct-slab-v3r3 with accumulated fixes and small tweaks > > and a new patch from Hyeonggon Yoo on top. To avoid too much spam, here's a range diff: > > Hi Vlastimil! > > I've started to review this patchset (btw, a really nice work, I like > the resulting code way more). Because I'm looking at v3 and I don't have > the whole v2 in my mailbox, here is what I've now: > > * mm: add virt_to_folio() and folio_address() > Reviewed-by: Roman Gushchin > > * mm/slab: Dissolve slab_map_pages() in its caller > Reviewed-by: Roman Gushchin > > * mm/slub: Make object_err() static > Reviewed-by: Roman Gushchin > > * mm: Split slab into its own type > 1) Shouldn't SLAB_MATCH() macro use struct folio instead of struct page for the > comparison? > 2) page_slab() is used only in kasan and only in one place, so maybe it's better > to not introduce it as a generic helper? > Other than that > Reviewed-by: Roman Gushchin > > * mm: Add account_slab() and unaccount_slab() > 1) maybe change the title to convert/replace instead of add? > 2) maybe move later changes to memcg_alloc_page_obj_cgroups() to this patch? > Reviewed-by: Roman Gushchin > > * mm: Convert virt_to_cache() to use struct slab > Reviewed-by: Roman Gushchin > > * mm: Convert __ksize() to struct slab > It looks like certain parts of __ksize() can be merged between slab, slub and slob? > Reviewed-by: Roman Gushchin > > * mm: Use struct slab in kmem_obj_info() > Reviewed-by: Roman Gushchin Part 2: * mm: Convert check_heap_object() to use struct slab Reviewed-by: Roman Gushchin * mm/slub: Convert detached_freelist to use a struct slab How about to convert free_nonslab_page() to free_nonslab_folio()? And maybe rename it to something like free_large_kmalloc()? If I'm not missing something, large kmallocs is the only way how we can end up there with a !slab folio/page. * mm/slub: Convert kfree() to use a struct slab Reviewed-by: Roman Gushchin * mm/slub: Convert __slab_lock() and __slab_unlock() to struct slab Reviewed-by: Roman Gushchin * mm/slub: Convert print_page_info() to print_slab_info() Do we really need to explicitly convert slab_folio()'s result to (struct folio *)? Reviewed-by: Roman Gushchin * mm/slub: Convert alloc_slab_page() to return a struct slab Reviewed-by: Roman Gushchin * mm/slub: Convert __free_slab() to use struct slab Reviewed-by: Roman Gushchin * mm/slub: Convert pfmemalloc_match() to take a struct slab Cool! Removing pfmemalloc_unsafe() is really nice. Reviewed-by: Roman Gushchin * mm/slub: Convert most struct page to struct slab by spatch Reviewed-by: Roman Gushchin * mm/slub: Finish struct page to struct slab conversion Reviewed-by: Roman Gushchin * mm/slab: Convert kmem_getpages() and kmem_freepages() to struct slab Reviewed-by: Roman Gushchin * mm/slab: Convert most struct page to struct slab by spatch Another patch with the same title? Rebase error? * mm/slab: Finish struct page to struct slab conversion And this one too? Thanks! Roman