From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A4A3C433EF for ; Tue, 14 Dec 2021 18:01:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF3546B0071; Tue, 14 Dec 2021 13:00:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2986B0073; Tue, 14 Dec 2021 13:00:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6B6B6B0074; Tue, 14 Dec 2021 13:00:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay034.a.hostedemail.com [64.99.140.34]) by kanga.kvack.org (Postfix) with ESMTP id AA05A6B0071 for ; Tue, 14 Dec 2021 13:00:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7A10F9A3 for ; Tue, 14 Dec 2021 18:00:45 +0000 (UTC) X-FDA: 78917165250.03.91E2F6A Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf18.hostedemail.com (Postfix) with ESMTP id C89771C0017 for ; Tue, 14 Dec 2021 18:00:39 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso14286892wmr.5 for ; Tue, 14 Dec 2021 10:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+IqBfvBvBmcxlYVp+0RytaxVZtHRcBsFFTjJF1k6GHc=; b=syl17ArW/Ro29Zbp9gxKSi9F6jrmZBzC7sLm3nzXi7EDGIQAhTsYLLNgRXk//55C88 FXwHZ4tjhLDscHK5n5Dc+L4fYzfAOUzN7KLxxGPCDCjo/OKaYq2czOXm+aWWSaQPikgD /By7bPwufuY0ptkpd2PNguMeBSwB+FFn+a3R8Q052GW/FrMn+vWAxAhXePCGp+AVHmol AqR1Qbscl47KT1NtO+1CpZYcaswAb8GIrg2HyXea0ttGSEeejRWKX/Js1p5f/YMOQOuy atrdpDXS/SwpEffOTYA/SMzSkIZwFj9/Sz7xu5tJZu8D9GPTVOgeemIpI/ZPrNSn1MHA CvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+IqBfvBvBmcxlYVp+0RytaxVZtHRcBsFFTjJF1k6GHc=; b=MNeg6NXyPx87yzp7yLcXjHaPbVRZvTetdo73EeGgTQnfpOWJWUbYJtcxo9ygioL1kr PtH9SfVmFryxmRDgTIXUdIT3LcxaJMSNTZP472FQs4j6WIEQF9c6d3cRNNtPdsgraw6M 0GcQf4A6FQlhuceTZK/bFJ9p80DTz8LK2mjhbt0F3FItnQzDPSPfDdxpx48q/LFX3GP6 OuL1l0ywhyW1cjrm6snawb3zL5XfocC6yA9eYlBTik/TnIa1eC+GMUfI7h0ilWrEW6gg G3h2JThEEYKwDAElHm/VRqVEbPwPWvzxQ62hYUFHAWR63b8rvAqyJE6QzYfSv6X71Z4D +h/w== X-Gm-Message-State: AOAM532j4HmjK0Njqsy3X52MIntOsQ/rmEdn6zWDeXNpEc5EFHrAcUNq ejxLQXemW6nMT2FApxY59Qb7Lw== X-Google-Smtp-Source: ABdhPJx8XGNeI01OLB/kBYng+fTDxbTRqMS8BklKCp38WxzksFwtBiBht2PK8HWQTUdS3kbX1RMVJg== X-Received: by 2002:a1c:f217:: with SMTP id s23mr694802wmc.70.1639504841398; Tue, 14 Dec 2021 10:00:41 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:b1a9:56e:da78:fa44]) by smtp.gmail.com with ESMTPSA id n36sm1316753wmr.2.2021.12.14.10.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 10:00:40 -0800 (PST) Date: Tue, 14 Dec 2021 19:00:35 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH mm v3 28/38] kasan, page_alloc: allow skipping memory init for HW_TAGS Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=syl17ArW; spf=pass (imf18.hostedemail.com: domain of elver@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C89771C0017 X-Stat-Signature: smunjoo67ncnot9b465z13w9e8c185df X-HE-Tag: 1639504839-944211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 13, 2021 at 10:54PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Add a new GFP flag __GFP_SKIP_ZERO that allows to skip memory > initialization. The flag is only effective with HW_TAGS KASAN. [...] > - * is being zeroed (either via __GFP_ZERO or via init_on_alloc). > + * is being zeroed (either via __GFP_ZERO or via init_on_alloc, provided that > + * __GFP_SKIP_ZERO is not set). > + * > + * %__GFP_SKIP_ZERO makes page_alloc skip zeroing memory. > + * Only effective when HW_TAGS KASAN is enabled. > * > * %__GFP_SKIP_KASAN_UNPOISON makes KASAN skip unpoisoning on page allocation. > * Only effective in HW_TAGS mode. > @@ -242,6 +247,7 @@ struct vm_area_struct; > #define __GFP_COMP ((__force gfp_t)___GFP_COMP) > #define __GFP_ZERO ((__force gfp_t)___GFP_ZERO) > #define __GFP_ZEROTAGS ((__force gfp_t)___GFP_ZEROTAGS) > +#define __GFP_SKIP_ZERO ((__force gfp_t)___GFP_SKIP_ZERO) > #define __GFP_SKIP_KASAN_UNPOISON ((__force gfp_t)___GFP_SKIP_KASAN_UNPOISON) > #define __GFP_SKIP_KASAN_POISON ((__force gfp_t)___GFP_SKIP_KASAN_POISON) > > @@ -249,7 +255,7 @@ struct vm_area_struct; > #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) > > /* Room for N __GFP_FOO bits */ > -#define __GFP_BITS_SHIFT (26 + IS_ENABLED(CONFIG_LOCKDEP)) > +#define __GFP_BITS_SHIFT (27 + IS_ENABLED(CONFIG_LOCKDEP)) You're adding several new flags, I think you should also make a corresponding change to include/trace/events/mmflags.h? At least __GFP_SKIP_KASAN_POISON is currently in there.