From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EE0C433EF for ; Tue, 14 Dec 2021 16:47:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D53256B0078; Tue, 14 Dec 2021 11:34:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D034A6B007B; Tue, 14 Dec 2021 11:34:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCAC26B007D; Tue, 14 Dec 2021 11:34:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay028.a.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id AE91F6B0078 for ; Tue, 14 Dec 2021 11:34:18 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7BCA92062F for ; Tue, 14 Dec 2021 16:34:08 +0000 (UTC) X-FDA: 78916946976.03.8B648A2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 03AC64000B for ; Tue, 14 Dec 2021 16:34:06 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D458615DC; Tue, 14 Dec 2021 16:34:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16AE6C34601; Tue, 14 Dec 2021 16:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1639499645; bh=y9Tsf9OdTgQ1kMcJ/PUzR3f3WRy9zX8FGn4p772Rqxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cem+MBYsmw3h/iOiG9hzHtrjGv9dTWO4AuNK0GROz1f2ChQbtSx4x27m1N4FRNlSr lUZdkVcdmebi4sWJC3EbA3fvJm+96jGmFyIpijLHmBSyBC8RKlzHgzv5GoGSVy2vi9 Bnp25aHWWpPAetVN26ZiedYmVNPwyBFGy5rT7YSc= Date: Tue, 14 Dec 2021 17:34:02 +0100 From: Greg Kroah-Hartman To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/43] kmsan: add KMSAN runtime core Message-ID: References: <20211214162050.660953-1-glider@google.com> <20211214162050.660953-14-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214162050.660953-14-glider@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 03AC64000B X-Stat-Signature: zrqhzyu5y7hotbcteqsanyabnzbr1847 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=cem+MBYs; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1639499646-893514 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 14, 2021 at 05:20:20PM +0100, Alexander Potapenko wrote: > This patch adds the core parts of KMSAN runtime and associated files: > > - include/linux/kmsan-checks.h: user API to poison/unpoison/check > the kernel memory; > - include/linux/kmsan.h: declarations of KMSAN hooks to be referenced > outside of KMSAN runtime; > - lib/Kconfig.kmsan: CONFIG_KMSAN and related declarations; > - Makefile, mm/Makefile, mm/kmsan/Makefile: boilerplate Makefile code; > - mm/kmsan/annotations.c: non-inlineable implementation of KMSAN_INIT(); > - mm/kmsan/core.c: core functions that operate with shadow and origin > memory and perform checks, utility functions; > - mm/kmsan/hooks.c: KMSAN hooks for kernel subsystems; > - mm/kmsan/init.c: KMSAN initialization routines; > - mm/kmsan/instrumentation.c: functions called by KMSAN instrumentation; > - mm/kmsan/kmsan.h: internal KMSAN declarations; > - mm/kmsan/shadow.c: routines that encapsulate metadata creation and > addressing; > - scripts/Makefile.kmsan: CFLAGS_KMSAN > - scripts/Makefile.lib: KMSAN_SANITIZE and KMSAN_ENABLE_CHECKS macros That's an odd way to write a changelog, don't you think? You need to describe what you are doing here and why you are doing it. Not a list of file names, we can see that in the diffstat. Also, you don't mention you are doing USB stuff here at all. And why are you doing it here? That should be added in a later patch. Break this up into smaller, logical, pieces that add the infrastructure and build on it. Don't just chop your patches up on a logical-file boundry, as you are adding stuff in this patch that you do not need for many more later on, which means it was not needed here. thanks, greg k-h