From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D03C433EF for ; Mon, 13 Dec 2021 04:23:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 993F66B0071; Sun, 12 Dec 2021 23:22:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9437B6B0073; Sun, 12 Dec 2021 23:22:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A8B6B0074; Sun, 12 Dec 2021 23:22:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 6EF976B0071 for ; Sun, 12 Dec 2021 23:22:56 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2D82582499B9 for ; Mon, 13 Dec 2021 04:22:46 +0000 (UTC) X-FDA: 78911475132.25.C75D675 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 1556C40007 for ; Mon, 13 Dec 2021 04:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5VRRrXTMpMMR1uAghzgqAdj8BzkVpuZ2ziBLrA4cdV4=; b=hHj5tkQLGXVF896zpGXpvorbmT ZeNp5ygUrTrFdisSuEOLwfYTwId2s25Z+kFrAh3Bfx1sO+hUFUfSrBRebvk3bJTxx9sEBCxskN2+Y YDQqZ7RRTWE9uCsWeke+790cXmml4bZs/a0LTmVF3/gQrc8iamJ0JXAvd98bK97f9gl8c8ZUKOqV+ UuUJxhBXa+r49x8eQpZAO5lumYIZqPGJui1b5Qo3Pbckxw/n4pKhbBDn8wLbe4UqP7zzgV48mCpul 0RFjFslQkUFDt8dh8faKufMuXOMHQdVNgmhtRzXG2YUbE8ntdKOakzvG6/E8tW4zczFlIyKVbaG5o ZrimuKjw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwcrG-00CR6G-4B; Mon, 13 Dec 2021 04:22:38 +0000 Date: Mon, 13 Dec 2021 04:22:38 +0000 From: Matthew Wilcox To: NeilBrown Cc: Andrew Morton , Mel Gorman , Philipp Reisner , Lars Ellenberg , Jan Kara , Ryusuke Konishi , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Remove inode_congested() Message-ID: References: <163936868317.23860.5037433897004720387.stgit@noble.brown> <163936886725.23860.2403757518009677424.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163936886725.23860.2403757518009677424.stgit@noble.brown> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1556C40007 X-Stat-Signature: iwubj7h38h4i3ek4yrqpdcoxedaiqamp Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hHj5tkQL; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1639369360-109356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 13, 2021 at 03:14:27PM +1100, NeilBrown wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index fb9584641ac7..540aa0ea67ff 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -989,17 +989,6 @@ static inline int is_page_cache_freeable(struct page *page) > return page_count(page) - page_has_private(page) == 1 + page_cache_pins; > } > > -static int may_write_to_inode(struct inode *inode) > -{ > - if (current->flags & PF_SWAPWRITE) > - return 1; > - if (!inode_write_congested(inode)) > - return 1; > - if (inode_to_bdi(inode) == current->backing_dev_info) > - return 1; > - return 0; > -} Why is it safe to get rid of the PF_SWAPWRITE and current->backing_dev_info checks? > @@ -1158,8 +1147,6 @@ static pageout_t pageout(struct page *page, struct address_space *mapping) > } > if (mapping->a_ops->writepage == NULL) > return PAGE_ACTIVATE; > - if (!may_write_to_inode(mapping->host)) > - return PAGE_KEEP; > > if (clear_page_dirty_for_io(page)) { > int res;