From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4F9C433F5 for ; Sun, 12 Dec 2021 06:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B746B0071; Sun, 12 Dec 2021 01:10:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3B246B0073; Sun, 12 Dec 2021 01:10:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B507A6B0074; Sun, 12 Dec 2021 01:10:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id A6FE26B0071 for ; Sun, 12 Dec 2021 01:10:30 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5CC28181AEF30 for ; Sun, 12 Dec 2021 06:10:20 +0000 (UTC) X-FDA: 78908117400.17.A01E6A0 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by imf29.hostedemail.com (Postfix) with ESMTP id 5A48E120004 for ; Sun, 12 Dec 2021 06:10:18 +0000 (UTC) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4JBZ4Q0SSxz64; Sun, 12 Dec 2021 07:10:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1639289416; bh=VuSaSqZcrW41+uEiAuo1l/ttygVpq/wNgVGxyoOZ6fE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Se5KLieRBNcATvBBOunx0rHx7HuEfdgOk9WDp7fVx4+6kG3zs28wFtU9k/J4M21SE zGcMLgd4EFo5i4VsU2OyUytJnB5P94a2dy7o+rL1f5PqdCY6d1I1l+qVZNYrcYWrnF emwF88A1fMLkqFpXhi+rmLgCnUB9GT6Lbk3X/XxfcLyE1I6QUX4ArcKzTP4BR8qAsC Z/viU6GxVCXZkj3WtqkWtv3+favkbkgBsXAzkniR9xhKmlcfQVqXMR9dhyt3143syq FQxwbfFM9ShuoiBiNVEdno8gl1Xr7tvt5T2BQs9wrkf2d59rFTKXbIXACuxeWnwjN6 a9cjxE1oiuL9g== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at mail Date: Sun, 12 Dec 2021 07:10:11 +0100 From: Michal Miroslaw To: Yafang Shao Cc: akpm@linux-foundation.org, rostedt@goodmis.org, keescook@chromium.org, pmladek@suse.com, david@redhat.com, arnaldo.melo@gmail.com, andrii.nakryiko@gmail.com, alexei.starovoitov@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Desnoyers , Peter Zijlstra , Matthew Wilcox , Al Viro Subject: Re: [PATCH -mm v2 2/3] cn_proc: replaced old hard-coded 16 with TASK_COMM_LEN_16 Message-ID: References: <20211211063949.49533-1-laoar.shao@gmail.com> <20211211063949.49533-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <20211211063949.49533-3-laoar.shao@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5A48E120004 X-Stat-Signature: wmgeqhuabxk1r3cyfa6ypnmumsea6po6 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=Se5KLieR; dmarc=pass (policy=reject) header.from=rere.qmqm.pl; spf=pass (imf29.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl X-HE-Tag: 1639289418-179044 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 11, 2021 at 06:39:48AM +0000, Yafang Shao wrote: > This TASK_COMM_LEN_16 has the same meaning with the macro defined in > linux/sched.h, but we can't include linux/sched.h in a UAPI header, so > we should specifically define it in the cn_proc.h. [...] > index db210625cee8..6dcccaed383f 100644 > --- a/include/uapi/linux/cn_proc.h > +++ b/include/uapi/linux/cn_proc.h > @@ -21,6 +21,8 @@ > =20 > #include > =20 > +#define TASK_COMM_LEN_16 16 Hi, Since this is added to UAPI header, maybe you could make it a single instance also used elsewhere? Even though this is constant and not going to change I don't really like multiplying the sources of truth. Best Regards Micha=B3 Miros=B3aw