From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688B9C433F5 for ; Fri, 10 Dec 2021 03:25:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9BD66B0074; Thu, 9 Dec 2021 22:25:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4E1C6B0075; Thu, 9 Dec 2021 22:25:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A128D6B0078; Thu, 9 Dec 2021 22:25:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay026.a.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 8E9D36B0074 for ; Thu, 9 Dec 2021 22:25:18 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 45645605B2 for ; Fri, 10 Dec 2021 03:25:08 +0000 (UTC) X-FDA: 78900443496.02.7FD1030 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf28.hostedemail.com (Postfix) with ESMTP id E2A02C0002 for ; Fri, 10 Dec 2021 03:25:07 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id p13so7293525pfw.2 for ; Thu, 09 Dec 2021 19:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lwj5GPmvS/i6jbubM1T0W+RpRaDna2NMTbylhTRqghs=; b=jlUZsuD90bsxm/0B8NKZsmOmbJcWH2r6kjQtyR73t8o5UL7RriwY71ZtY8RO0+io8z M/0NwENtKjfJCg5EkLz7dgnPE1cS64xsz0iCfQTiDdEVBRuZAIYj4XiC+6fYKLKm+i+N GvyPdxnXAhopayQa845VVno+W0AVu92T9E4UUvy9Ro43s48ATKz/kRKQGqD94ZEUicC4 NJo1KTTAcmcINC+M0umFy/Bkusy4eWtFYsi6DopLW+iKZ9gP091D5JF1eCQ6I61egX4s RryUu/WD871jAkcw9djnTEukyFEEDk41nfJnv/99sU0aALf0aN5GZctanx0hOIkTfoUX FUgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=lwj5GPmvS/i6jbubM1T0W+RpRaDna2NMTbylhTRqghs=; b=toN3dFOdvSJZLcou13ECtYiN+FJgFf/O4fkJxOZ4kMdWKLvIusI6MBR4kqjryd2HLE 4HhXsTduliL9ybEuR7hnNf89YIudtZ/gySMSc8uc/gr2VQQB/SdmwMD1y1cHaOnRSQtT H92ktmx7/d4lJsfZf1lT3M2GIN9Y9559WBTbS09iHdU3vtRxH07IQ00idubzk1SOYAaf rNXqvD9svXB6LlorIetXHJSJFEUcqLsyR/YBfIJx5l8lKIOnsPkI2AbhimbRAb2VL+0M JXt6njKt6Tj1jrsLU+RQZFDcbPsglkMiABrvxzUOjVzal4/eKpp2Dqx26JnYwx0eOoWR MV5A== X-Gm-Message-State: AOAM5308qljeHyLE4LERCEHO4Ah2MVBKeDEcD3fg6n6eYCgRRadLE5kS 04T2PWORsoTzNm3EV2gZXDE= X-Google-Smtp-Source: ABdhPJz8BRVYad2uWHre9t0yBMsCAfON+259789eDQMmI9H8vdOZP3lb5Cb/4qsQQ4aVD9kZQEtKew== X-Received: by 2002:a05:6a00:ad0:b0:4a3:1056:e2ae with SMTP id c16-20020a056a000ad000b004a31056e2aemr15441245pfl.2.1639106706893; Thu, 09 Dec 2021 19:25:06 -0800 (PST) Received: from google.com ([2620:15c:211:201:85e0:23ee:fbe7:282b]) by smtp.gmail.com with ESMTPSA id pc10sm1082527pjb.9.2021.12.09.19.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 19:25:06 -0800 (PST) Date: Thu, 9 Dec 2021 19:25:04 -0800 From: Minchan Kim To: Miaohe Lin Cc: Andrew Morton , Jens Axboe , linux-mm , LKML , Suren Baghdasaryan , John Dias Subject: Re: [PATCH] mm/madvise: pageout under plugging Message-ID: References: <20211210003019.1481269-1-minchan@kernel.org> <6d844eda-a55a-d90c-d8bc-364ac8b17690@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d844eda-a55a-d90c-d8bc-364ac8b17690@huawei.com> X-Rspamd-Queue-Id: E2A02C0002 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jlUZsuD9; spf=pass (imf28.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam04 X-Stat-Signature: 8khrky6ejgc1fjhpjtojdajacptietcy X-HE-Tag: 1639106707-847490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 10, 2021 at 10:02:24AM +0800, Miaohe Lin wrote: > Hi: > On 2021/12/10 8:30, Minchan Kim wrote: > > Likewise shrink_lruvec[1], madvise_pageout could get the benefit > > from per-task block plug. > > > > [1] 3da367c3e5fc, vmscan: add block plug for page reclaim > > It seems there is a block plug in the caller do_madvise already. This one > might not be necessary for madvise. I missed the place where it was already doing. I will drop it. Thanks for the catch.