From: Minchan Kim <minchan@kernel.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
John Dias <joaodias@google.com>
Subject: Re: [PATCH] mm/madvise: pageout under plugging
Date: Thu, 9 Dec 2021 19:25:04 -0800 [thread overview]
Message-ID: <YbLIkAsiLy8flTIN@google.com> (raw)
In-Reply-To: <6d844eda-a55a-d90c-d8bc-364ac8b17690@huawei.com>
On Fri, Dec 10, 2021 at 10:02:24AM +0800, Miaohe Lin wrote:
> Hi:
> On 2021/12/10 8:30, Minchan Kim wrote:
> > Likewise shrink_lruvec[1], madvise_pageout could get the benefit
> > from per-task block plug.
> >
> > [1] 3da367c3e5fc, vmscan: add block plug for page reclaim
>
> It seems there is a block plug in the caller do_madvise already. This one
> might not be necessary for madvise.
I missed the place where it was already doing.
I will drop it.
Thanks for the catch.
prev parent reply other threads:[~2021-12-10 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 0:30 Minchan Kim
2021-12-10 2:02 ` Miaohe Lin
2021-12-10 3:25 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbLIkAsiLy8flTIN@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=joaodias@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox