linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dennis Zhou <dennis@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
	Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH v1 1/1] percpu_ref: Replace kernel.h with the necessary inclusions
Date: Thu, 9 Dec 2021 15:40:06 -0500	[thread overview]
Message-ID: <YbJppiVtI+F5Pda1@fedora> (raw)
In-Reply-To: <20211209123033.3492-1-andriy.shevchenko@linux.intel.com>

Hello,

On Thu, Dec 09, 2021 at 02:30:33PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
> 
> Replace kernel.h inclusion with the list of what is really being used.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/linux/percpu-refcount.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
> index b31d3f3312ce..d73a1c08c3e3 100644
> --- a/include/linux/percpu-refcount.h
> +++ b/include/linux/percpu-refcount.h
> @@ -51,9 +51,9 @@
>  #define _LINUX_PERCPU_REFCOUNT_H
>  
>  #include <linux/atomic.h>
> -#include <linux/kernel.h>
>  #include <linux/percpu.h>
>  #include <linux/rcupdate.h>
> +#include <linux/types.h>
>  #include <linux/gfp.h>
>  
>  struct percpu_ref;
> -- 
> 2.33.0
> 

Applied to for-5.16-fixes.

Thanks,
Dennis


      reply	other threads:[~2021-12-09 20:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 12:30 Andy Shevchenko
2021-12-09 20:40 ` Dennis Zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbJppiVtI+F5Pda1@fedora \
    --to=dennis@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=asml.silence@gmail.com \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox