From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03273C433EF for ; Wed, 8 Dec 2021 20:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DDE46B0071; Wed, 8 Dec 2021 15:55:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78E426B0073; Wed, 8 Dec 2021 15:55:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655B16B0074; Wed, 8 Dec 2021 15:55:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 530266B0071 for ; Wed, 8 Dec 2021 15:55:52 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 17CE418578FE9 for ; Wed, 8 Dec 2021 20:55:42 +0000 (UTC) X-FDA: 78895833324.12.130E497 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 448B61046280 for ; Wed, 8 Dec 2021 20:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e0av1DdKA6IByIYuV+WI1PzAoi3CS3Y42D0EdbIPCFg=; b=B17zQy3eOMQUrtOqIvyWjTYkyD WhO0NiNydB0Yv/mnFL0JDLzbrFCtUcgZRkW8qaryNOlYCmkGgHUC2Gf9QsD2ez97s6NVbFlPQ9t1F +7KWPnmaCC4ptLOJmjkIq/hR7/NtGJny7xm6sT8sAVRJNtYyig9Vq2lzS/XY+0XikkDft0f8YUQ0c KLjcPOIRVTJRmOOp9262pbqzLIDe/wvwTyOKptwnSCw8ZJAd2AcyUwo6OlCi3ikuYhrMkZm1ru9NM 1orRSuMM/E6If5PQVhS3EBRjKLZnwunz83ynVfmSpGz78GEiw5KNmsGdZk551Kj5qIhVhgtmeR+CF bpfVQVcg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv3yJ-008ldr-8j; Wed, 08 Dec 2021 20:55:27 +0000 Date: Wed, 8 Dec 2021 20:55:27 +0000 From: Matthew Wilcox To: Pasha Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, anshuman.khandual@arm.com, akpm@linux-foundation.org, william.kucharski@oracle.com, mike.kravetz@oracle.com, vbabka@suse.cz, geert@linux-m68k.org, schmitzmic@gmail.com, rostedt@goodmis.org, mingo@redhat.com, hannes@cmpxchg.org, guro@fb.com, songmuchun@bytedance.com, weixugc@google.com, gthelen@google.com, rientjes@google.com, pjt@google.com Subject: Re: [PATCH 01/10] mm: page_ref_add_unless() does not trace 'u' argument Message-ID: References: <20211208203544.2297121-1-pasha.tatashin@soleen.com> <20211208203544.2297121-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208203544.2297121-2-pasha.tatashin@soleen.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 448B61046280 X-Stat-Signature: babd5zg8rmhgta9jzyuibyjg73abz7xq Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B17zQy3e; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1638996938-662815 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 08:35:35PM +0000, Pasha Tatashin wrote: > In other page_ref_* functions all arguments and returns are traced, but > in page_ref_add_unless the 'u' argument which stands for unless boolean > is not traced. However, what is more confusing is that in the tracing > routine: > __page_ref_mod_unless(struct page *page, int v, int u); > > The 'u' argument present, but instead a return value is passed into > this argument. > > Add a new template specific for page_ref_add_unless(), and trace all > arguments and the return value. The special casing of '1' for device pages is going away, so NAK to this user-visible change.